From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] drm/omapdrm: don't call drm_helper_disable_unused_functions Date: Fri, 10 Jun 2016 09:24:51 +0300 Message-ID: <575A5D33.10608@ti.com> References: <2357538.tkpZ3RiU5H@avalon> <1465510479-21180-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0885819418==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8EA436EC6D for ; Fri, 10 Jun 2016 06:24:58 +0000 (UTC) In-Reply-To: <1465510479-21180-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============0885819418== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DalAiCWCfBgnJ1R0RF6wUGVJjN7gHSUx0" --DalAiCWCfBgnJ1R0RF6wUGVJjN7gHSUx0 Content-Type: multipart/mixed; boundary="QWxoroGGB06Hjo9FcD5U3ds7dIetHd6x8" From: Tomi Valkeinen To: Daniel Vetter , DRI Development Cc: Laurent Pinchart , Daniel Vetter Message-ID: <575A5D33.10608@ti.com> Subject: Re: [PATCH] drm/omapdrm: don't call drm_helper_disable_unused_functions References: <2357538.tkpZ3RiU5H@avalon> <1465510479-21180-1-git-send-email-daniel.vetter@ffwll.ch> In-Reply-To: <1465510479-21180-1-git-send-email-daniel.vetter@ffwll.ch> --QWxoroGGB06Hjo9FcD5U3ds7dIetHd6x8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/06/16 01:14, Daniel Vetter wrote: > It's a legacy helper function which won't do good with atomic helpers. >=20 > Cc: Tomi Valkeinen > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/oma= pdrm/omap_fbdev.c > index 31dfa0893416..adb10fbe918d 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -279,9 +279,6 @@ struct drm_fb_helper *omap_fbdev_init(struct drm_de= vice *dev) > if (ret) > goto fini; > =20 > - /* disable all the possible outputs/crtcs before entering KMS mode */= > - drm_helper_disable_unused_functions(dev); > - > ret =3D drm_fb_helper_initial_config(helper, 32); > if (ret) > goto fini; >=20 Acked-by: Tomi Valkeinen --QWxoroGGB06Hjo9FcD5U3ds7dIetHd6x8-- --DalAiCWCfBgnJ1R0RF6wUGVJjN7gHSUx0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXWl0zAAoJEPo9qoy8lh71gpEP/1rQeYi+RLecJpLreToXbbt3 BATF2YJlN6hjwHZvJYYXYLNlsDrN+Z0etpV6vUevU3kKtFOsVdewH7jeoEf6nho0 kPTzvxZ155xZennNPOjIJgymYFheRhHOvcKcWjqvSf71OD8Up9dqQTHdw5piQtx2 7LdL21mE2939ulbJrQSgNkEwxpsl7EpoaeaBSrcru0j0EHCJMTZA3F5LdkHM5zLc 4WVcbpwE4SilMy5fFF0BVCZYdoT5pT1eq8D6lvnN776B2KdpKyQMDbnUPizhSW57 iCKpSVwGnTanaKaMtWc8R75P7J0883yZY9N3obVUful8Tq2W9Pt2Fgxf/MFVBPmT 4tBF9lPmhe5WRTQhwMK+PxLLbE2Dy8WltHOf+OoX6vQMOAil6qTZslX6u4iDYqM5 2MkU/GZm1zwLGO/YWHggiHrS4Sh80vWaE1kmEtptGq7PTKF5l5wBA1ciehFJOjO0 MAn3pa25g0i0kdI0Ow6F5TZtPbKBKH0Ep/ktq2EfEfugm0BRQis0Buo8+7vtNRk+ CBGpBJ3jdTLexRR+ONlbvSy7y1RX8sOB98WVq55A0jHB9o8IfNLBXH5JLechx/TX jn1ztxr7VxQJrSeIv8/VnawrZ3fUSXhRqikzbBMHSHb1lN2zz9hqYOASzdiXcck2 3c+n4MRCKpYj3h3OKK9r =KC76 -----END PGP SIGNATURE----- --DalAiCWCfBgnJ1R0RF6wUGVJjN7gHSUx0-- --===============0885819418== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0885819418==--