From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH] drm/omapdrm: don't call
 drm_helper_disable_unused_functions
Date: Fri, 10 Jun 2016 09:26:42 +0300
Message-ID: <575A5DA2.4040605@ti.com>
References: <2357538.tkpZ3RiU5H@avalon>
 <1465510479-21180-1-git-send-email-daniel.vetter@ffwll.ch>
 <575A5D33.10608@ti.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0094343655=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E22CC6EC73
 for <dri-devel@lists.freedesktop.org>; Fri, 10 Jun 2016 06:26:48 +0000 (UTC)
In-Reply-To: <575A5D33.10608@ti.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>
List-Id: dri-devel@lists.freedesktop.org

--===============0094343655==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="bPIiroGcFWP8C4MxgtA5r1GvbTrDslHd4"

--bPIiroGcFWP8C4MxgtA5r1GvbTrDslHd4
Content-Type: multipart/mixed; boundary="3SrSMpn3JtJ3V20FCJGBANaDE7QweBTxI"
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
 DRI Development <dri-devel@lists.freedesktop.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Daniel Vetter <daniel.vetter@intel.com>
Message-ID: <575A5DA2.4040605@ti.com>
Subject: Re: [PATCH] drm/omapdrm: don't call
 drm_helper_disable_unused_functions
References: <2357538.tkpZ3RiU5H@avalon>
 <1465510479-21180-1-git-send-email-daniel.vetter@ffwll.ch>
 <575A5D33.10608@ti.com>
In-Reply-To: <575A5D33.10608@ti.com>

--3SrSMpn3JtJ3V20FCJGBANaDE7QweBTxI
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 10/06/16 09:24, Tomi Valkeinen wrote:
> On 10/06/16 01:14, Daniel Vetter wrote:
>> It's a legacy helper function which won't do good with atomic helpers.=

>>
>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>> ---
>>  drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/om=
apdrm/omap_fbdev.c
>> index 31dfa0893416..adb10fbe918d 100644
>> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
>> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
>> @@ -279,9 +279,6 @@ struct drm_fb_helper *omap_fbdev_init(struct drm_d=
evice *dev)
>>  	if (ret)
>>  		goto fini;
>> =20
>> -	/* disable all the possible outputs/crtcs before entering KMS mode *=
/
>> -	drm_helper_disable_unused_functions(dev);
>> -
>>  	ret =3D drm_fb_helper_initial_config(helper, 32);
>>  	if (ret)
>>  		goto fini;
>>
>=20
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Ops, my mail client was too eager to send this... I was about to ask if
I should pick this up?

 Tomi


--3SrSMpn3JtJ3V20FCJGBANaDE7QweBTxI--

--bPIiroGcFWP8C4MxgtA5r1GvbTrDslHd4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXWl2iAAoJEPo9qoy8lh71sOEP/0isBEWukRybpY6NzRDQ3B1G
feSWbOEpbc5edGf1MdED6FfJCyvmd29pNrqSoXhwloBt0JLWYOSN7G196lmYkn6t
qoRa5bgm7QMNRHAaHPNqxEaFD7KlWCBIbh+cYbXZDnhIkaGuKQKSjeuUmt7OlV6u
9h6u5l617i4ZBpfayWcKVL3+zDYXfcby4B23iyQZlrTLDssRD5RDSpCuc2C0OwQA
iUZWej/21OxFFFf0FCRZp2//uanXqIxp7g0Q+lTfLnFHFWqgGKzL+hL7hGTBwm9v
CvA9Tj0n1g8b2VFrXPtftLqA+hoj84PlxB45y2l3HiovwBTOoO51lwAX/oHhJLPo
3VxGQf6dBkS/kvevgF0zMVuiBBKWLxd3xcTuQ94xoqiNpPiWU4oouam8QONKzLWO
6rjuJfkLy5TXGrQHuXEZp05gGLY4NxjQi+dBKcomYOxTJXx94CyoUVjtFq2LrSTC
N5vY1IWb8ph6Z0IBbGyCJJipu8ofB3dw2viSrbmWnA5jtq2IMl2B439r8VkvRz7D
hy1TBmhyDDJtAICNwZH4UWYffrfx0d6RrbUUmJId/Pvygi7F+yPRtExf1/EiLA35
ZHvaA3da1wnMxhfJiOGGTVQfkEc79XS5yQ+i28L/pnj2p4a7H8gdOq/LBs7BUhFv
gYS7ebyprkcqP+PLZc6+
=ZiyN
-----END PGP SIGNATURE-----

--bPIiroGcFWP8C4MxgtA5r1GvbTrDslHd4--

--===============0094343655==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0094343655==--