From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFC PATCH 04/15] irqchip: exynos_combiner: fixup reg access on be Date: Fri, 10 Jun 2016 13:44:40 +0200 Message-ID: <575AA828.3070805@samsung.com> References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-5-matthew@mattleach.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:51697 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbcFJLop (ORCPT ); Fri, 10 Jun 2016 07:44:45 -0400 In-reply-to: <20160608183110.13851-5-matthew@mattleach.net> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Matthew Leach , Ben Dooks Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Jason Cooper , Marc Zyngier , Kukjin Kim On 06/08/2016 08:30 PM, Matthew Leach wrote: > Use the byte-order aware big endian accessors, allowing for kernels > running under big-endian. > > Signed-off-by: Matthew Leach > --- > CC: Thomas Gleixner > CC: Jason Cooper > CC: Marc Zyngier > CC: Kukjin Kim > CC: Krzysztof Kozlowski > CC: linux-kernel@vger.kernel.org > CC: linux-arm-kernel@lists.infradead.org > CC: linux-samsung-soc@vger.kernel.org > --- > drivers/irqchip/exynos-combiner.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c > index ead15be..b78a169 100644 > --- a/drivers/irqchip/exynos-combiner.c > +++ b/drivers/irqchip/exynos-combiner.c > @@ -55,14 +55,14 @@ static void combiner_mask_irq(struct irq_data *data) > { > u32 mask = 1 << (data->hwirq % 32); > > - __raw_writel(mask, combiner_base(data) + COMBINER_ENABLE_CLEAR); > + writel_relaxed(mask, combiner_base(data) + COMBINER_ENABLE_CLEAR); > } > > static void combiner_unmask_irq(struct irq_data *data) > { > u32 mask = 1 << (data->hwirq % 32); > > - __raw_writel(mask, combiner_base(data) + COMBINER_ENABLE_SET); > + writel_relaxed(mask, combiner_base(data) + COMBINER_ENABLE_SET); > } > > static void combiner_handle_cascade_irq(struct irq_desc *desc) > @@ -75,7 +75,7 @@ static void combiner_handle_cascade_irq(struct irq_desc *desc) > chained_irq_enter(chip, desc); > > spin_lock(&irq_controller_lock); > - status = __raw_readl(chip_data->base + COMBINER_INT_STATUS); > + status = readl_relaxed(chip_data->base + COMBINER_INT_STATUS); > spin_unlock(&irq_controller_lock); > status &= chip_data->irq_mask; > > @@ -135,7 +135,7 @@ static void __init combiner_init_one(struct combiner_chip_data *combiner_data, > combiner_data->parent_irq = irq; > > /* Disable all interrupts */ > - __raw_writel(combiner_data->irq_mask, base + COMBINER_ENABLE_CLEAR); > + writel_relaxed(combiner_data->irq_mask, base + COMBINER_ENABLE_CLEAR); > } > > static int combiner_irq_domain_xlate(struct irq_domain *d, > @@ -218,7 +218,7 @@ static int combiner_suspend(void) > > for (i = 0; i < max_nr; i++) > combiner_data[i].pm_save = > - __raw_readl(combiner_data[i].base + COMBINER_ENABLE_SET); > + readl_relaxed(combiner_data[i].base + COMBINER_ENABLE_SET); > > return 0; > } > @@ -235,9 +235,9 @@ static void combiner_resume(void) > int i; > > for (i = 0; i < max_nr; i++) { > - __raw_writel(combiner_data[i].irq_mask, > + writel_relaxed(combiner_data[i].irq_mask, > combiner_data[i].base + COMBINER_ENABLE_CLEAR); > - __raw_writel(combiner_data[i].pm_save, > + writel_relaxed(combiner_data[i].pm_save, > combiner_data[i].base + COMBINER_ENABLE_SET); Indentation of arguments is broken. I think it was aligned before. Beside that: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 10 Jun 2016 13:44:40 +0200 Subject: [RFC PATCH 04/15] irqchip: exynos_combiner: fixup reg access on be In-Reply-To: <20160608183110.13851-5-matthew@mattleach.net> References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-5-matthew@mattleach.net> Message-ID: <575AA828.3070805@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/08/2016 08:30 PM, Matthew Leach wrote: > Use the byte-order aware big endian accessors, allowing for kernels > running under big-endian. > > Signed-off-by: Matthew Leach > --- > CC: Thomas Gleixner > CC: Jason Cooper > CC: Marc Zyngier > CC: Kukjin Kim > CC: Krzysztof Kozlowski > CC: linux-kernel at vger.kernel.org > CC: linux-arm-kernel at lists.infradead.org > CC: linux-samsung-soc at vger.kernel.org > --- > drivers/irqchip/exynos-combiner.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c > index ead15be..b78a169 100644 > --- a/drivers/irqchip/exynos-combiner.c > +++ b/drivers/irqchip/exynos-combiner.c > @@ -55,14 +55,14 @@ static void combiner_mask_irq(struct irq_data *data) > { > u32 mask = 1 << (data->hwirq % 32); > > - __raw_writel(mask, combiner_base(data) + COMBINER_ENABLE_CLEAR); > + writel_relaxed(mask, combiner_base(data) + COMBINER_ENABLE_CLEAR); > } > > static void combiner_unmask_irq(struct irq_data *data) > { > u32 mask = 1 << (data->hwirq % 32); > > - __raw_writel(mask, combiner_base(data) + COMBINER_ENABLE_SET); > + writel_relaxed(mask, combiner_base(data) + COMBINER_ENABLE_SET); > } > > static void combiner_handle_cascade_irq(struct irq_desc *desc) > @@ -75,7 +75,7 @@ static void combiner_handle_cascade_irq(struct irq_desc *desc) > chained_irq_enter(chip, desc); > > spin_lock(&irq_controller_lock); > - status = __raw_readl(chip_data->base + COMBINER_INT_STATUS); > + status = readl_relaxed(chip_data->base + COMBINER_INT_STATUS); > spin_unlock(&irq_controller_lock); > status &= chip_data->irq_mask; > > @@ -135,7 +135,7 @@ static void __init combiner_init_one(struct combiner_chip_data *combiner_data, > combiner_data->parent_irq = irq; > > /* Disable all interrupts */ > - __raw_writel(combiner_data->irq_mask, base + COMBINER_ENABLE_CLEAR); > + writel_relaxed(combiner_data->irq_mask, base + COMBINER_ENABLE_CLEAR); > } > > static int combiner_irq_domain_xlate(struct irq_domain *d, > @@ -218,7 +218,7 @@ static int combiner_suspend(void) > > for (i = 0; i < max_nr; i++) > combiner_data[i].pm_save = > - __raw_readl(combiner_data[i].base + COMBINER_ENABLE_SET); > + readl_relaxed(combiner_data[i].base + COMBINER_ENABLE_SET); > > return 0; > } > @@ -235,9 +235,9 @@ static void combiner_resume(void) > int i; > > for (i = 0; i < max_nr; i++) { > - __raw_writel(combiner_data[i].irq_mask, > + writel_relaxed(combiner_data[i].irq_mask, > combiner_data[i].base + COMBINER_ENABLE_CLEAR); > - __raw_writel(combiner_data[i].pm_save, > + writel_relaxed(combiner_data[i].pm_save, > combiner_data[i].base + COMBINER_ENABLE_SET); Indentation of arguments is broken. I think it was aligned before. Beside that: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof