From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 09/15] drm: tilcdc: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp() Date: Fri, 10 Jun 2016 15:26:30 +0300 Message-ID: <575AB1F6.4040805@ti.com> References: <1465428739-26529-1-git-send-email-laurent.pinchart@ideasonboard.com> <1465428739-26529-10-git-send-email-laurent.pinchart@ideasonboard.com> <575AA9D1.7090002@ti.com> <20160610120537.GH4329@intel.com> <575AADB2.70609@ti.com> <20160610122310.GJ4329@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0463655952==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id D94076ED1E for ; Fri, 10 Jun 2016 12:26:43 +0000 (UTC) In-Reply-To: <20160610122310.GJ4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , Jyri Sarha , Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0463655952== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AefA1sRGmHSlPs4e6xtkeKb1gAIaUAGfp" --AefA1sRGmHSlPs4e6xtkeKb1gAIaUAGfp Content-Type: multipart/mixed; boundary="Jm30x3fq9C0exdKOTLtKrGoFdkOuuXGU4" From: Tomi Valkeinen To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, Daniel Vetter , Eric Engestrom , Jyri Sarha Message-ID: <575AB1F6.4040805@ti.com> Subject: Re: [PATCH v3 09/15] drm: tilcdc: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp() References: <1465428739-26529-1-git-send-email-laurent.pinchart@ideasonboard.com> <1465428739-26529-10-git-send-email-laurent.pinchart@ideasonboard.com> <575AA9D1.7090002@ti.com> <20160610120537.GH4329@intel.com> <575AADB2.70609@ti.com> <20160610122310.GJ4329@intel.com> In-Reply-To: <20160610122310.GJ4329@intel.com> --Jm30x3fq9C0exdKOTLtKrGoFdkOuuXGU4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/06/16 15:23, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Jun 10, 2016 at 03:08:18PM +0300, Tomi Valkeinen wrote: >> On 10/06/16 15:05, Ville Syrj=C3=A4l=C3=A4 wrote: >> >>>> I'm not sure what's the common way, but tilcdc doesn't support alpha= =2E >>>> ARGB works, of course, by ignoring A, but... If an userspace app cre= ates >>>> ARGB buffer, does the app expect alpha to work? >>> >>> I think what we decided a while ago (at least for i915, but would be = good >>> to use the same convention everywhere) was that ARGB will be assumed = to be >>> pre-multiplied and will enable blending using 1.0*sc+(1.0-sa)*dc as t= he >>> function. There have been some efforts at defining some new propertie= s to >>> control the blend equation, but I guess those got bogged down again. >> >> Ok, but that's a bit different topic. The question here is, if the HW >> doesn't support alpha (no planes, so nothing to blend), should it acce= pt >> ARGB or not. >=20 > What do you mean "no planes"? You have to have a plane if you want > to scanout a framebuffer. And even if you have just one plane with > alpha blending, it should be blended with the background color > (which is black until we get a property to change it). I mean there's only the crtc with fb. So yes, one plane if you want to call that a plane. The HW does not support any kind of blending to black or to anything else. Tomi --Jm30x3fq9C0exdKOTLtKrGoFdkOuuXGU4-- --AefA1sRGmHSlPs4e6xtkeKb1gAIaUAGfp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXWrH2AAoJEPo9qoy8lh71mW0P/0acWMmyYTxZ2UsjmCt0gvi+ 9I19agxFC+oF4q9OSXwqPLjFUa0D7PTDQfjiZQgfDy1hF8WZetKfgKR/AkN5wuzj 7qwNp1thPrSN3jxxvXrkMc2zXFok+ezTh9oOx7aSYZo9gWXAMTSgjBEwd4fzCXy7 NB4t5pIwfmvabM/focVIPOyhPdiuTSvp+y685Sgrd1+BiyGvw717pcrUOjXRVSVf WqI+0/+PviaKZin7KU+vjjcVXVP2HAFCquSoRHYbxNiaHIvZeBissGHXt0ZyCDNd jLpPEfjjal80iejGgRLPPAy79W5JNm7wi+MtTvRDpDOKqdGpFiKrG8SMninWe/xe oTSmCkXOGvX+9PX+EtchRfksLEDWqNdaAEGlgJmiaJ6RblrOgrdJVI7kMki6EDYr BVkjzzvKCez/aZ4HzU2rwD7AS4iVUqc2j+bo9HxUam86kQTULMx9JpxBDYJUORzF rh587FeOpSNyoYeG0CkQV23gv6asubAzv483trRy4q3kIeiMU0pw3N0gp7RxYCdc yMzG4dEYgLBOkmqViDviHRDLqTwXEg+/nHBNr/KVrvKeLI3bBNC663d2lpBRYnEg tYr9FnSeYt9yD8da31uNMTwe9hNvJBsTu5D3AUCpKdPob0QhuJGOK2vAVyXbM23t Vb+Eu2Drcd4TT5UiJehs =7M1M -----END PGP SIGNATURE----- --AefA1sRGmHSlPs4e6xtkeKb1gAIaUAGfp-- --===============0463655952== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0463655952==--