From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFC PATCH 07/15] ARM: exynos: fixup debug macros for big-endian Date: Fri, 10 Jun 2016 15:04:52 +0200 Message-ID: <575ABAF4.3030809@samsung.com> References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-8-matthew@mattleach.net> <575AA193.7040907@samsung.com> <17ac39d6-d451-ed43-1aa6-f2af462a61e0@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:25672 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbcFJNE5 (ORCPT ); Fri, 10 Jun 2016 09:04:57 -0400 In-reply-to: <17ac39d6-d451-ed43-1aa6-f2af462a61e0@codethink.co.uk> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Ben Dooks , Matthew Leach Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 06/10/2016 03:02 PM, Ben Dooks wrote: > On 10/06/16 12:16, Krzysztof Kozlowski wrote: >> On 06/10/2016 01:12 PM, Ben Dooks wrote: >>> On 08/06/16 19:31, Matthew Leach wrote: >>>> From: Ben Dooks >>>> >>>> The exynos low-level debug macros need to be fixed if the system is being >>>> built big endian. Add the necessary endian swaps for accessing the registers >>>> to get output working again >>>> >>>> Signed-off-by: Ben Dooks >>>> --- >>>> arch/arm/include/debug/samsung.S | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>> >>> Should this go via the maintainer or to RMK? >>> >>> If to RMK, then shall I get it submitted (and does anyone else >>> want to ack?) >> >> If there are no objections, I can take it through samsung-soc with other >> arch/arm/mach-exynos* patches. >> >> What I am missing here, is Matthew's Signed-off-by. >> >> Matthew, you touched and sent the patch so could you add the Sob? > > I've asked Matthew to re-send the core patches with the signed-off > sorted out. Thanks. > He can also put them on a public facing git server if > that would be helpful. No need. I think it will go through separate trees anyway. Except the change adding ARCH_SUPPORTS_BIG_ENDIAN, I don't see any dependencies. As for the ARCH_SUPPORTS_BIG_ENDIAN, I think it should be applied when all necessary drivers are fixed. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 10 Jun 2016 15:04:52 +0200 Subject: [RFC PATCH 07/15] ARM: exynos: fixup debug macros for big-endian In-Reply-To: <17ac39d6-d451-ed43-1aa6-f2af462a61e0@codethink.co.uk> References: <20160608183110.13851-1-matthew@mattleach.net> <20160608183110.13851-8-matthew@mattleach.net> <575AA193.7040907@samsung.com> <17ac39d6-d451-ed43-1aa6-f2af462a61e0@codethink.co.uk> Message-ID: <575ABAF4.3030809@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/10/2016 03:02 PM, Ben Dooks wrote: > On 10/06/16 12:16, Krzysztof Kozlowski wrote: >> On 06/10/2016 01:12 PM, Ben Dooks wrote: >>> On 08/06/16 19:31, Matthew Leach wrote: >>>> From: Ben Dooks >>>> >>>> The exynos low-level debug macros need to be fixed if the system is being >>>> built big endian. Add the necessary endian swaps for accessing the registers >>>> to get output working again >>>> >>>> Signed-off-by: Ben Dooks >>>> --- >>>> arch/arm/include/debug/samsung.S | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>> >>> Should this go via the maintainer or to RMK? >>> >>> If to RMK, then shall I get it submitted (and does anyone else >>> want to ack?) >> >> If there are no objections, I can take it through samsung-soc with other >> arch/arm/mach-exynos* patches. >> >> What I am missing here, is Matthew's Signed-off-by. >> >> Matthew, you touched and sent the patch so could you add the Sob? > > I've asked Matthew to re-send the core patches with the signed-off > sorted out. Thanks. > He can also put them on a public facing git server if > that would be helpful. No need. I think it will go through separate trees anyway. Except the change adding ARCH_SUPPORTS_BIG_ENDIAN, I don't see any dependencies. As for the ARCH_SUPPORTS_BIG_ENDIAN, I think it should be applied when all necessary drivers are fixed. Best regards, Krzysztof