All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicolai Hähnle" <nhaehnle@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] xf86drm: ensure proper alignment of pointers in drmProcessPciDevice
Date: Fri, 10 Jun 2016 16:07:50 +0200	[thread overview]
Message-ID: <575AC9B6.2060907@gmail.com> (raw)
In-Reply-To: <1463120076-9253-1-git-send-email-nhaehnle@gmail.com>

Ping.

On 13.05.2016 08:14, Nicolai Hähnle wrote:
> From: Nicolai Hähnle <nicolai.haehnle@amd.com>
>
> Previously, (*device)->businfo.pci would end up misaligned, which results
> in undefined behavior.
>
> Signed-off-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
> ---
>   xf86drm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index 5f587d9..94efc08 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -3000,7 +3000,7 @@ static int drmProcessPciDevice(drmDevicePtr *device, const char *d_name,
>                                  const char *node, int node_type,
>                                  int maj, int min, bool fetch_deviceinfo)
>   {
> -    const int max_node_str = drmGetMaxNodeName();
> +    const int max_node_str = ALIGN(drmGetMaxNodeName(), sizeof(void *));
>       int ret, i;
>       char *addr;
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-06-10 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13  6:14 [PATCH] xf86drm: ensure proper alignment of pointers in drmProcessPciDevice Nicolai Hähnle
2016-05-14 23:03 ` Emil Velikov
2016-05-17 15:24   ` Nicolai Hähnle
2016-06-10 14:07 ` Nicolai Hähnle [this message]
2016-06-10 16:55   ` Emil Velikov
2016-06-10 18:19     ` Nicolai Hähnle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575AC9B6.2060907@gmail.com \
    --to=nhaehnle@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.