From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v3 1/1] leds: LED driver for TI LP3952 6-Channel Color LED Date: Fri, 10 Jun 2016 16:36:49 +0200 Message-ID: <575AD081.7040200@samsung.com> References: <1465469168-6286-1-git-send-email-tony.makkiel@daqri.com> <57595CE5.70905@samsung.com> <57598927.6060207@daqri.com> <575A79AD.2030700@samsung.com> <575AA707.8090704@daqri.com> <575AB8E3.4000401@daqri.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:27687 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932114AbcFJOgy (ORCPT ); Fri, 10 Jun 2016 10:36:54 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O8K00AY38LE3PA0@mailout4.w1.samsung.com> for linux-leds@vger.kernel.org; Fri, 10 Jun 2016 15:36:50 +0100 (BST) In-reply-to: <575AB8E3.4000401@daqri.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Tony Makkiel Cc: linux-leds@vger.kernel.org, rpurdie@rpsys.net, rjw@rjwysocki.net, lenb@kernel.org On 06/10/2016 02:56 PM, Tony Makkiel wrote: > > > >>>>>> + >>>>>> +#ifdef CONFIG_ACPI >>>>>> +static const struct acpi_device_id lp3952_acpi_match[] = { >>>>>> + {LP3952_NAME, 0}, >>>>>> + {} >>>>>> +}; >>>>> >>>>> Could you please share how did you apply ACPI overlay? >>>> >>>> I am using the initrd ACPI method of Octavian's patch. >>>> >>>> https://lkml.org/lkml/2016/3/31/333 >>> >>> Thanks. Would it be possible to define entries per each LED >>> connected to the LED controller, similarly as it is in case >>> of Device Tree bindings?: >>> >>> Documentation/devicetree/bindings/leds/common.txt >>> >> >> I am not sure. I did a quick skim through ACPI Spec 5.0. >> But couldn't find anything. > > Found it!, although not relevant for this driver. Please > see last page of > http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf Great. The "Package" entries seem to use names compatible with the Device Tree properties documented in Documentation/devicetree/bindings/leds/common.txt. Probably you could also provide LED name in the "Name" entry and obtain them in the driver directly from ACPI, similarly as it is accomplished in case of Device Tree. led_name array from lp3952_register_led_classdev() could be removed then. -- Best regards, Jacek Anaszewski