From mboxrd@z Thu Jan  1 00:00:00 1970
From: dave.long@linaro.org (David Long)
Date: Fri, 10 Jun 2016 10:54:55 -0400
Subject: [PATCH v13 02/10] arm64: Add more test functions to insn.c
In-Reply-To: <20160608101401.7296820ea6ac082ef1c917cb@kernel.org>
References: <1464924384-15269-1-git-send-email-dave.long@linaro.org>
 <1464924384-15269-3-git-send-email-dave.long@linaro.org>
 <20160608101401.7296820ea6ac082ef1c917cb@kernel.org>
Message-ID: <575AD4BF.8010000@linaro.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 06/07/2016 09:14 PM, Masami Hiramatsu wrote:
> On Thu,  2 Jun 2016 23:26:16 -0400
> David Long <dave.long@linaro.org> wrote:
>> @@ -367,6 +402,7 @@ bool aarch32_insn_is_wide(u32 insn);
>>   #define A32_RT_OFFSET	12
>>   #define A32_RT2_OFFSET	 0
>>
>> +u32 aarch64_extract_system_register(u32 insn);
>
> This exported symbol is incorrect (see below)
>
>>   u32 aarch32_insn_extract_reg_num(u32 insn, int offset);
>>   u32 aarch32_insn_mcr_extract_opc2(u32 insn);
>>   u32 aarch32_insn_mcr_extract_crm(u32 insn);
>> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
>> index 368c082..28c6110f 100644
>> --- a/arch/arm64/kernel/insn.c
>> +++ b/arch/arm64/kernel/insn.c
> [..]
>> @@ -1175,6 +1201,14 @@ u32 aarch64_set_branch_offset(u32 insn, s32 offset)
>>   	BUG();
>>   }
>>
>> +/*
>> + * Extract the Op/CR data from a msr/mrs instruction.
>> + */
>> +u32 aarch64_insn_extract_system_reg(u32 insn)
>> +{
>> +	return (insn & 0x1FFFE0) >> 5;
>> +}
>> +
>
> aarch64_insn_extract_system_reg() is the right name :)
>
> Thank you,
>
>
>>   bool aarch32_insn_is_wide(u32 insn)
>>   {
>>   	return insn >= 0xe800;
>> --
>> 2.5.0
>>
>
>

Thanks for finding that.

-dl

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932750AbcFJOzE (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 10:55:04 -0400
Received: from mail-qk0-f170.google.com ([209.85.220.170]:35488 "EHLO
	mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751724AbcFJOzB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 10:55:01 -0400
Subject: Re: [PATCH v13 02/10] arm64: Add more test functions to insn.c
To: Masami Hiramatsu <mhiramat@kernel.org>
References: <1464924384-15269-1-git-send-email-dave.long@linaro.org>
 <1464924384-15269-3-git-send-email-dave.long@linaro.org>
 <20160608101401.7296820ea6ac082ef1c917cb@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        Huang Shijie <shijie.huang@arm.com>, James Morse <james.morse@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Pratyush Anand <panand@redhat.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        Will Deacon <will.deacon@arm.com>, William Cohen <wcohen@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steve Capper <steve.capper@linaro.org>,
        Li Bin <huawei.libin@huawei.com>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Dave P Martin <Dave.Martin@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Jisheng Zhang <jszhang@marvell.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Yang Shi <yang.shi@linaro.org>, Zi Shen Lim <zlim.lnx@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>, Mark Brown <broonie@kernel.org>
From: David Long <dave.long@linaro.org>
Message-ID: <575AD4BF.8010000@linaro.org>
Date: Fri, 10 Jun 2016 10:54:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20160608101401.7296820ea6ac082ef1c917cb@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/07/2016 09:14 PM, Masami Hiramatsu wrote:
> On Thu,  2 Jun 2016 23:26:16 -0400
> David Long <dave.long@linaro.org> wrote:
>> @@ -367,6 +402,7 @@ bool aarch32_insn_is_wide(u32 insn);
>>   #define A32_RT_OFFSET	12
>>   #define A32_RT2_OFFSET	 0
>>
>> +u32 aarch64_extract_system_register(u32 insn);
>
> This exported symbol is incorrect (see below)
>
>>   u32 aarch32_insn_extract_reg_num(u32 insn, int offset);
>>   u32 aarch32_insn_mcr_extract_opc2(u32 insn);
>>   u32 aarch32_insn_mcr_extract_crm(u32 insn);
>> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
>> index 368c082..28c6110f 100644
>> --- a/arch/arm64/kernel/insn.c
>> +++ b/arch/arm64/kernel/insn.c
> [..]
>> @@ -1175,6 +1201,14 @@ u32 aarch64_set_branch_offset(u32 insn, s32 offset)
>>   	BUG();
>>   }
>>
>> +/*
>> + * Extract the Op/CR data from a msr/mrs instruction.
>> + */
>> +u32 aarch64_insn_extract_system_reg(u32 insn)
>> +{
>> +	return (insn & 0x1FFFE0) >> 5;
>> +}
>> +
>
> aarch64_insn_extract_system_reg() is the right name :)
>
> Thank you,
>
>
>>   bool aarch32_insn_is_wide(u32 insn)
>>   {
>>   	return insn >= 0xe800;
>> --
>> 2.5.0
>>
>
>

Thanks for finding that.

-dl