Re: [Qemu-devel] [PATCH] nbd: Don't use *_to_cpup() functions

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On 06/10/2016 09:00 AM, Peter Maydell wrote:
> The *_to_cpup() functions are not very useful, as they simply do
> a pointer dereference and then a *_to_cpu(). Instead use either:
>  * ld*_*_p(), if the data is at an address that might not be
>    correctly aligned for the load
>  * a local dereference and *_to_cpu(), if the pointer is
>    the correct type and known to be correctly aligned
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The motivation is to be able to drop *_to_cpup() entirely;
> we don't have many places that use it.
> ---
>  nbd/client.c |  8 ++++----
>  nbd/server.c | 10 +++++-----
>  qemu-nbd.c   |  4 ++--
>  3 files changed, 11 insertions(+), 11 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]