From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Date: Sun, 12 Jun 2016 10:05:21 +0800 Message-ID: <575CC361.4080003@rock-chips.com> References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386762-27816-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?St=c3=a9phane_Marchesin?= Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Linux Kernel list , Rob Herring , "dri-devel@lists.freedesktop.org" , Kumar Gala List-Id: devicetree@vger.kernel.org U3TDqXBoYW5lLAoKT24gMDYvMTAvMjAxNiAwODowNCBBTSwgU3TDqXBoYW5lIE1hcmNoZXNpbiB3 cm90ZToKPiBPbiBXZWQsIEp1biA4LCAyMDE2IGF0IDQ6NTIgQU0sIFlha2lyIFlhbmcgPHlra0By b2NrLWNoaXBzLmNvbT4gd3JvdGU6Cj4+IFRoZSBTYW1zdW5nIExTTjEyMkRMMDEtQzAxIGlzIGFu IDEyLjIiIDI1NjB4MTYwMCAoV1FYR0EpIFRGVC1MQ0QgcGFuZWwKPj4gY29ubmVjdGVkIHVzaW5n IGVEUCBpbnRlcmZhY2VzLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9j ay1jaGlwcy5jb20+Cj4+IC0tLQo+PiBDaGFuZ2VzIGluIHYyOiBOb25lCj4+Cj4+ICAgZHJpdmVy cy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysr KysrKwo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9k cm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPj4gaW5kZXggNDEwMjBlMS4uMDY3YTVjNCAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+PiBAQCAtMTI0Niw2ICsxMjQ2LDI4 IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyBxZDQzMDAzYzBfNDAgPSB7Cj4+ICAg ICAgICAgIC5idXNfZm9ybWF0ID0gTUVESUFfQlVTX0ZNVF9SR0I4ODhfMVgyNCwKPj4gICB9Owo+ Pgo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIHNhbXN1bmdfbHNuMTIy ZGwwMV9jMDFfbW9kZSA9IHsKPj4gKyAgICAgICAuY2xvY2sgPSAyNzE1NjAsCj4+ICsgICAgICAg LmhkaXNwbGF5ID0gMjU2MCwKPj4gKyAgICAgICAuaHN5bmNfc3RhcnQgPSAyNTYwICsgNDgsCj4+ ICsgICAgICAgLmhzeW5jX2VuZCA9IDI1NjAgKyA0OCArIDMyLAo+PiArICAgICAgIC5odG90YWwg PSAyNTYwICsgNDggKyAzMiArIDgwLAo+PiArICAgICAgIC52ZGlzcGxheSA9IDE2MDAsCj4+ICsg ICAgICAgLnZzeW5jX3N0YXJ0ID0gMTYwMCArIDIsCj4+ICsgICAgICAgLnZzeW5jX2VuZCA9IDE2 MDAgKyAyICsgNSwKPj4gKyAgICAgICAudnRvdGFsID0gMTYwMCArIDIgKyA1ICsgNTcsCj4+ICsg ICAgICAgLnZyZWZyZXNoID0gNjAsCj4+ICt9Owo+PiArCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0 IHBhbmVsX2Rlc2Mgc2Ftc3VuZ19sc24xMjJkbDAxX2MwMSA9IHsKPj4gKyAgICAgICAubW9kZXMg PSAmc2Ftc3VuZ19sc24xMjJkbDAxX2MwMV9tb2RlLAo+PiArICAgICAgIC5udW1fbW9kZXMgPSAx LAo+PiArICAgICAgIC5zaXplID0gewo+PiArICAgICAgICAgICAgICAgLndpZHRoID0gMjU2MCwK Pj4gKyAgICAgICAgICAgICAgIC5oZWlnaHQgPSAxNjAwLAo+IFRoZXNlIGFyZSBtZWFudCB0byBi ZSB0aGUgcGh5c2ljYWwgZGltZW5zaW9ucyAoc2FtZSB0aGluZyBmb3IgdGhlCj4gb3RoZXIgcGF0 Y2hlcyBidHcpLgoKR290IGl0LCBzbyB0aGlzIHNob3VsZCBiZSB0aGUgImFjdGl2ZSBhcmVhIiBp biBwYW5lbCBib29rLgpEaXNwbGF5IGFyZWEgICAgIDI2Mi42NTYoSCkgWCAxNjQuMTYoVikgICAg ICAgICAoMTIuMuKAnWRpYWdvbmFsKQoKClRoYW5rcywKLVlha2lyCgo+IFN0w6lwaGFuZQo+Cj4+ ICsgICAgICAgfSwKPj4gK307Cj4+ICsKPj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9kaXNw bGF5X21vZGUgc2Ftc3VuZ19sdG4xMDFudDA1X21vZGUgPSB7Cj4+ICAgICAgICAgIC5jbG9jayA9 IDU0MDMwLAo+PiAgICAgICAgICAuaGRpc3BsYXkgPSAxMDI0LAo+PiBAQCAtMTUwNiw2ICsxNTI4 LDkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgcGxhdGZvcm1fb2ZfbWF0Y2hb XSA9IHsKPj4gICAgICAgICAgICAgICAgICAuY29tcGF0aWJsZSA9ICJxaWFvZGlhbixxZDQzMDAz YzAtNDAiLAo+PiAgICAgICAgICAgICAgICAgIC5kYXRhID0gJnFkNDMwMDNjMF80MCwKPj4gICAg ICAgICAgfSwgewo+PiArICAgICAgICAgICAgICAgLmNvbXBhdGlibGUgPSAic2Ftc3VuZyxsc24x MjJkbDAxLWMwMSIsCj4+ICsgICAgICAgICAgICAgICAuZGF0YSA9ICZzYW1zdW5nX2xzbjEyMmRs MDFfYzAxLAo+PiArICAgICAgIH0sIHsKPj4gICAgICAgICAgICAgICAgICAuY29tcGF0aWJsZSA9 ICJzYW1zdW5nLGx0bjEwMW50MDUiLAo+PiAgICAgICAgICAgICAgICAgIC5kYXRhID0gJnNhbXN1 bmdfbHRuMTAxbnQwNSwKPj4gICAgICAgICAgfSwgewo+PiAtLQo+PiAxLjkuMQo+Pgo+Pgo+PiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPgo+ CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbcFLCFe (ORCPT ); Sat, 11 Jun 2016 22:05:34 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:39341 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbcFLCFc (ORCPT ); Sat, 11 Jun 2016 22:05:32 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: dri-devel@lists.freedesktop.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel To: =?UTF-8?Q?St=c3=a9phane_Marchesin?= References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386762-27816-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , devicetree@vger.kernel.org, Linux Kernel list , "dri-devel@lists.freedesktop.org" From: Yakir Yang Message-ID: <575CC361.4080003@rock-chips.com> Date: Sun, 12 Jun 2016 10:05:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stéphane, On 06/10/2016 08:04 AM, Stéphane Marchesin wrote: > On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang wrote: >> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel >> connected using eDP interfaces. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v2: None >> >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 41020e1..067a5c4 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = { >> .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >> }; >> >> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = { >> + .clock = 271560, >> + .hdisplay = 2560, >> + .hsync_start = 2560 + 48, >> + .hsync_end = 2560 + 48 + 32, >> + .htotal = 2560 + 48 + 32 + 80, >> + .vdisplay = 1600, >> + .vsync_start = 1600 + 2, >> + .vsync_end = 1600 + 2 + 5, >> + .vtotal = 1600 + 2 + 5 + 57, >> + .vrefresh = 60, >> +}; >> + >> +static const struct panel_desc samsung_lsn122dl01_c01 = { >> + .modes = &samsung_lsn122dl01_c01_mode, >> + .num_modes = 1, >> + .size = { >> + .width = 2560, >> + .height = 1600, > These are meant to be the physical dimensions (same thing for the > other patches btw). Got it, so this should be the "active area" in panel book. Display area 262.656(H) X 164.16(V) (12.2”diagonal) Thanks, -Yakir > Stéphane > >> + }, >> +}; >> + >> static const struct drm_display_mode samsung_ltn101nt05_mode = { >> .clock = 54030, >> .hdisplay = 1024, >> @@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = { >> .compatible = "qiaodian,qd43003c0-40", >> .data = &qd43003c0_40, >> }, { >> + .compatible = "samsung,lsn122dl01-c01", >> + .data = &samsung_lsn122dl01_c01, >> + }, { >> .compatible = "samsung,ltn101nt05", >> .data = &samsung_ltn101nt05, >> }, { >> -- >> 1.9.1 >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > >