From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Date: Sun, 12 Jun 2016 10:09:16 +0800 Message-ID: <575CC44C.5030702@rock-chips.com> References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386753-27730-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Mark Rutland , devicetree , Pawel Moll , Ian Campbell , "Linux-Kernel@Vger. Kernel. Org" , Rob Herring , ML dri-devel , Kumar Gala List-Id: devicetree@vger.kernel.org RW1pbCwKCk9uIDA2LzA4LzIwMTYgMDg6MjAgUE0sIEVtaWwgVmVsaWtvdiB3cm90ZToKPiBIaSBZ YWtpciwKPgo+IE9uIDggSnVuZSAyMDE2IGF0IDEyOjUyLCBZYWtpciBZYW5nIDx5a2tAcm9jay1j aGlwcy5jb20+IHdyb3RlOgo+PiBUaGUgTEcgTFAwOTdRWDEtU1BBMSBpcyBhbiA5LjciLCAyMDQ4 eDE1MzYgKFFYR0EpIFRGVC1MQ0QgcGFuZWwKPj4gY29ubmVjdGVkIHVzaW5nIGVEUCBpbnRlcmZh Y2VzLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+ Cj4+IC0tLQo+PiBDaGFuZ2VzIGluIHYyOiBOb25lCj4+Cj4+ICAgZHJpdmVycy9ncHUvZHJtL3Bh bmVsL3BhbmVsLXNpbXBsZS5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgIDEg ZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFu ZWwtc2ltcGxlLmMKPj4gaW5kZXggM2E3YmRmMS4uNDEwMjBlMSAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+PiBAQCAtMTA0MCw2ICsxMDQwLDI4IEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyBsZ19scDEyMHVwMSA9IHsKPj4gICAgICAgICAgfSwKPj4g ICB9Owo+Pgo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIGxnX2xwMDk3 cXgxX3NwYTFfbW9kZSA9IHsKPiBJIGJlbGlldmUgdGhhdCBsZ19scDA5N3F4MV9zcGExIHNob3Vs ZCBiZSBtb3ZlZC9zb3J0ZWQgYmVmb3JlIGxnX2xwMTIwdXAxLgoKQWgsIHllcywgZG9uZSAgOikK Cj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgbGdfbHAwOTdxeDFfc3BhMSA9IHsK Pj4gKyAgICAgICAubW9kZXMgPSAmbGdfbHAwOTdxeDFfc3BhMV9tb2RlLAo+PiArICAgICAgIC5u dW1fbW9kZXMgPSAxLAo+PiArICAgICAgIC5zaXplID0gewo+PiArICAgICAgICAgICAgICAgLndp ZHRoID0gMjA0OCwKPj4gKyAgICAgICAgICAgICAgIC5oZWlnaHQgPSAxNTM2LAo+IFRoZXNlIGFy ZSB0aGUgcGh5c2ljYWwgZGltZW5zaW9ucyBvZiB0aGUgcGFuZWwuIEZyb20gdGhlIGRvY3VtZW50 YXRpb24KPiAoYXQgdGhlIHRvcCBvZiB0aGUgZmlsZSkKPgo+IEB3aWR0aDogd2lkdGggKGluIG1p bGxpbWV0ZXJzKSBvZiB0aGUgcGFuZWwncyBhY3RpdmUgZGlzcGxheSBhcmVhCj4gLi4uCgpHb3Qg aXQsIHRoaXMgc2hvdWxkIGJlIHRoZSAiZGlzcGxheSBhcmVhIgpEaXNwbGF5IGFyZWEgICAgIDI2 Mi42NTYoSCkgWCAxNjQuMTYoVikgICAgICAgICAoMTIuMuKAnWRpYWdvbmFsKQoKVGhhbmtzLAot IFlha2lyCgo+Cj4gVGhpZXJyeSwgcGVyaGFwcyBpdCdzIHdvcnRoIHJlbmFtaW5nICdzaXplJyBp dCB0bwo+ICJwaHlzaWNhbF97c2l6ZSxkaW1lbnNpb25zfSIgYW5kL29yIGFsaWtlIHRvIG1ha2Ug aXQgY2xlYXJlciA/Cj4gTG9va3MgbGlrZSB3ZSBoYXZlIGEgZmV3IGNhc2VzIHdlcmUgcGVvcGxl IGdvdCBjb25mdXNlZCAtCj4gaW5ub2x1eF96ajA3MG5hXzAxcCBhbmQgc2Ftc3VuZ19sdG4xMDFu dDA1Lgo+Cj4gUmVnYXJkcywKPiBFbWlsCj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbcFLCJk (ORCPT ); Sat, 11 Jun 2016 22:09:40 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:41408 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbcFLCJi (ORCPT ); Sat, 11 Jun 2016 22:09:38 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: dri-devel@lists.freedesktop.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <042f5a86fdbf6c6610d0ebe65ca2c226> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel To: Emil Velikov References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386753-27730-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , devicetree , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel From: Yakir Yang Message-ID: <575CC44C.5030702@rock-chips.com> Date: Sun, 12 Jun 2016 10:09:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Emil, On 06/08/2016 08:20 PM, Emil Velikov wrote: > Hi Yakir, > > On 8 June 2016 at 12:52, Yakir Yang wrote: >> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel >> connected using eDP interfaces. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v2: None >> >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 3a7bdf1..41020e1 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = { >> }, >> }; >> >> +static const struct drm_display_mode lg_lp097qx1_spa1_mode = { > I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1. Ah, yes, done :) >> +static const struct panel_desc lg_lp097qx1_spa1 = { >> + .modes = &lg_lp097qx1_spa1_mode, >> + .num_modes = 1, >> + .size = { >> + .width = 2048, >> + .height = 1536, > These are the physical dimensions of the panel. From the documentation > (at the top of the file) > > @width: width (in millimeters) of the panel's active display area > ... Got it, this should be the "display area" Display area 262.656(H) X 164.16(V) (12.2”diagonal) Thanks, - Yakir > > Thierry, perhaps it's worth renaming 'size' it to > "physical_{size,dimensions}" and/or alike to make it clearer ? > Looks like we have a few cases were people got confused - > innolux_zj070na_01p and samsung_ltn101nt05. > > Regards, > Emil > > >