From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Date: Sun, 12 Jun 2016 10:12:20 +0800 Message-ID: <575CC504.9040301@rock-chips.com> References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386768-27947-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: Mark Rutland , "devicetree@vger.kernel.org" , Pawel Moll , Ian Campbell , "linux-kernel@vger.kernel.org" , Rob Herring , "dri-devel@lists.freedesktop.org" , Kumar Gala List-Id: devicetree@vger.kernel.org RG91ZywKCk9uIDA2LzExLzIwMTYgMTI6MTEgQU0sIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4gSGks Cj4KPiBPbiBXZWQsIEp1biA4LCAyMDE2IGF0IDk6MzUgQU0sIERvdWcgQW5kZXJzb24gPGRpYW5k ZXJzQGNocm9taXVtLm9yZz4gd3JvdGU6Cj4+IFlha2lyLAo+Pgo+PiBPbiBXZWQsIEp1biA4LCAy MDE2IGF0IDQ6NTIgQU0sIFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBzLmNvbT4gd3JvdGU6Cj4+ PiBUaGUgU2hhcnAgTFExMjNQMUpYMzEgaXMgYW4gMTIuMyIsIDI0MDB4MTYwMCBURlQtTENEIHBh bmVsIGNvbm5lY3RlZAo+Pj4gdXNpbmcgZURQIGludGVyZmFjZXMuCj4+Pgo+Pj4gU2lnbmVkLW9m Zi1ieTogWWFraXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPgo+Pj4gLS0tCj4+PiBDaGFuZ2Vz IGluIHYyOgo+Pj4gLSBBZGQgZGV0YWlsIHRpbWluZyBvZiBTaGFycCBMUTEyM1AxSlgzMSBwYW5l bCBpbiB2Mgo+Pj4KPj4+ICAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jIHwg MjYgKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDI2IGlu c2VydGlvbnMoKykKPj4gTG9va3MgZ29vZCB0byBtZS4gIFZhbHVlcyBpbiB0aGUgdGFibGUgbWF0 Y2ggdGhlIEVESUQgSSBzZWUgZnJvbSB0aGlzCj4+IHBhbmVsIGFuZCBldmVyeXRoaW5nIGVsc2Ug bG9va3MgdG8gYmUgaW4gb3JkZXIuCj4+Cj4+IFJldmlld2VkLWJ5OiBEb3VnIEFuZGVyc29uIDxk aWFuZGVyc0BjaHJvbWl1bS5vcmc+Cj4+IFRlc3RlZC1ieTogRG91ZyBBbmRlcnNvbiA8ZGlhbmRl cnNAY2hyb21pdW0ub3JnPgo+IFNvcnJ5IGZvciBub3Qgbm90aWNpbmcuICA6KCAgLi4uYnV0IGFz IG90aGVycyBoYXZlIHBvaW50ZWQgb3V0IGZvcgo+IHlvdXIgZWFybGllciBwYXRjaGVzLCB0aGUg c2l6ZSBpcyBpbmNvcnJlY3QuICBJIGZvdW5kIHRoZSBjb3JyZWN0IHNpemUKPiBhbmQgaXQgc2hv dWxkIGJlOgo+Cj4gICAgICAgICAgICAgICAgIC53aWR0aCA9IDI1OSwKPiAgICAgICAgICAgICAg ICAgLmhlaWdodCA9IDE3MywKPgoKQWgsIHRoYW5rcywgd291bGQgY29ycmVjdCBpdCBub3cgOi1E CgotIFlha2lyCgo+IC1Eb3VnCj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbcFLCMc (ORCPT ); Sat, 11 Jun 2016 22:12:32 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:60671 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbcFLCMb (ORCPT ); Sat, 11 Jun 2016 22:12:31 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <79223c0913c18dbbe62c0ca19c4fa93d> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel To: Doug Anderson References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386768-27947-1-git-send-email-ykk@rock-chips.com> Cc: David Airlie , Thierry Reding , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Yakir Yang Message-ID: <575CC504.9040301@rock-chips.com> Date: Sun, 12 Jun 2016 10:12:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, On 06/11/2016 12:11 AM, Doug Anderson wrote: > Hi, > > On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson wrote: >> Yakir, >> >> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang wrote: >>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected >>> using eDP interfaces. >>> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v2: >>> - Add detail timing of Sharp LQ123P1JX31 panel in v2 >>> >>> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >> Looks good to me. Values in the table match the EDID I see from this >> panel and everything else looks to be in order. >> >> Reviewed-by: Doug Anderson >> Tested-by: Doug Anderson > Sorry for not noticing. :( ...but as others have pointed out for > your earlier patches, the size is incorrect. I found the correct size > and it should be: > > .width = 259, > .height = 173, > Ah, thanks, would correct it now :-D - Yakir > -Doug > > >