From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Date: Sun, 12 Jun 2016 10:14:19 +0800 Message-ID: <575CC57B.6050404@rock-chips.com> References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386765-27867-1-git-send-email-ykk@rock-chips.com> <20160610134217.GA25881@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson , Rob Herring Cc: Mark Rutland , "devicetree@vger.kernel.org" , Pawel Moll , Ian Campbell , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Kumar Gala List-Id: devicetree@vger.kernel.org Ck9uIDA2LzExLzIwMTYgMTI6NDAgQU0sIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4gUm9iLAo+Cj4g T24gRnJpLCBKdW4gMTAsIDIwMTYgYXQgNjo0MiBBTSwgUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVs Lm9yZz4gd3JvdGU6Cj4+IE9uIFdlZCwgSnVuIDA4LCAyMDE2IGF0IDA3OjUyOjQ1UE0gKzA4MDAs IFlha2lyIFlhbmcgd3JvdGU6Cj4+PiBUaGUgU2hhcnAgTFExMjNQMUpYMzEgaXMgYW4gMTIuMyIg MjQwMHgxNjAwIFRGVC1MQ0QgcGFuZWwKPj4+IGNvbm5lY3RlZCB1c2luZyBlRFAgaW50ZXJmYWNl cy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+ Cj4+PiAtLS0KPj4+IENoYW5nZXMgaW4gdjI6Cj4+PiAtIEFkZCBkdC1iaW5kaW5ncyBvZiBTaGFy cCBMUTEyM1AxSlgzMSBwYW5lbCBpbiB2Mgo+Pj4KPj4+ICAgLi4uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9wYW5lbC9zaGFycCxscTEyM3AxangzMS50eHQgICAgICAgIHwgNyArKysrKysr Cj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPj4+ICAgY3JlYXRlIG1vZGUg MTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3No YXJwLGxxMTIzcDFqeDMxLnR4dAo+Pj4KPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaGFycCxscTEyM3AxangzMS50eHQgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaGFycCxscTEy M3AxangzMS50eHQKPj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+PiBpbmRleCAwMDAwMDAwLi44 MTkzOGMwCj4+PiAtLS0gL2Rldi9udWxsCj4+PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaGFycCxscTEyM3AxangzMS50eHQKPj4+IEBAIC0w LDAgKzEsNyBAQAo+Pj4gK1NoYXJwIDEyLjMiICgyNDAweDE2MDAgcGl4ZWxzKSBURlQgTENEIHBh bmVsCj4+PiArCj4+PiArUmVxdWlyZWQgcHJvcGVydGllczoKPj4+ICstIGNvbXBhdGlibGU6IHNo b3VsZCBiZSAic2hhcnAsbHExMjNwMWp4MzEsIgo+PiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXgo+PiBOZWVkIHRvIGRyb3AgdGhlIGNvbW1hLgo+IFRoYW5r cyBmb3IgY2F0Y2hpbmchCgpEb25lLAoKPgo+PiBObyByZWd1bGF0b3JzIG9yIHJlc2V0cyBvciBw d21zPwo+IENvdWxkIGJlIG1vcmUgZXhwbGljaXQgSSBndWVzcywgYnV0IFlha2lyIGRvZXMgc2F5 Ogo+Cj4+IFRoaXMgYmluZGluZyBpcyBjb21wYXRpYmxlIHdpdGggdGhlIHNpbXBsZS1wYW5lbCBi aW5kaW5nLCB3aGljaCBpcyBzcGVjaWZpZWQKPj4gaW4gc2ltcGxlLXBhbmVsLnR4dCBpbiB0aGlz IGRpcmVjdG9yeS4KPiBJbiB0aGF0IGRvY3VtZW50IGl0IHNob3dzOgo+Cj4gUmVxdWlyZWQgcHJv cGVydGllczoKPiAtIHBvd2VyLXN1cHBseTogcmVndWxhdG9yIHRvIHByb3ZpZGUgdGhlIHN1cHBs eSB2b2x0YWdlCj4KPiBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+IC0gZGRjLWkyYy1idXM6IHBoYW5k bGUgb2YgYW4gSTJDIGNvbnRyb2xsZXIgdXNlZCBmb3IgRERDIEVESUQgcHJvYmluZwo+IC0gZW5h YmxlLWdwaW9zOiBHUElPIHBpbiB0byBlbmFibGUgb3IgZGlzYWJsZSB0aGUgcGFuZWwKPiAtIGJh Y2tsaWdodDogcGhhbmRsZSBvZiB0aGUgYmFja2xpZ2h0IGRldmljZSBhdHRhY2hlZCB0byB0aGUg cGFuZWwKPgo+Cj4gSW4gZ2VuZXJhbCBZYWtpcidzIGJpbmRpbmdzIGRvY3VtZW50IG1hdGNoIGEg aHVnZSBjaHVuayBvZiB0aGUgY3VycmVudAo+IGV4aXN0aW5nIGJpbmRpbmdzLiAgRG8gdGhpczoK PiAgICBjZCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbAo+ ICAgIGdyZXAgLUMyMCAiVGhpcyBiaW5kaW5nIGlzIGNvbXBhdGlibGUgd2l0aCB0aGUgc2ltcGxl LXBhbmVsIiAqCj4KPiBZb3UnbGwgZmluZCBhIGh1Z2UgY2h1bmsgb2YgZmlsZXMgd2hpY2ggYXJl IHJhdGhlciBmb3JtdWxhaWMuICBJdAo+IG1pZ2h0IG1ha2Ugc2Vuc2UgdG8ganVzdCBoYXZlIG9u ZSBmaWxlIGFuZCBhIGxpc3Qgb2YgcGFuZWxzIHdoaWNoIGFyZQo+IHNpbXBsZSBwYW5lbHM/Cj4K Pgo+IC1Eb3VnCj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbcFLCOa (ORCPT ); Sat, 11 Jun 2016 22:14:30 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:42122 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbcFLCO3 (ORCPT ); Sat, 11 Jun 2016 22:14:29 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding To: Doug Anderson , Rob Herring References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386765-27867-1-git-send-email-ykk@rock-chips.com> <20160610134217.GA25881@rob-hp-laptop> Cc: David Airlie , Thierry Reding , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Yakir Yang Message-ID: <575CC57B.6050404@rock-chips.com> Date: Sun, 12 Jun 2016 10:14:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2016 12:40 AM, Doug Anderson wrote: > Rob, > > On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring wrote: >> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >>> connected using eDP interfaces. >>> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v2: >>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >>> >>> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> >>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> new file mode 100644 >>> index 0000000..81938c0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> @@ -0,0 +1,7 @@ >>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >>> + >>> +Required properties: >>> +- compatible: should be "sharp,lq123p1jx31," >> ^ >> Need to drop the comma. > Thanks for catching! Done, > >> No regulators or resets or pwms? > Could be more explicit I guess, but Yakir does say: > >> This binding is compatible with the simple-panel binding, which is specified >> in simple-panel.txt in this directory. > In that document it shows: > > Required properties: > - power-supply: regulator to provide the supply voltage > > Optional properties: > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > - enable-gpios: GPIO pin to enable or disable the panel > - backlight: phandle of the backlight device attached to the panel > > > In general Yakir's bindings document match a huge chunk of the current > existing bindings. Do this: > cd Documentation/devicetree/bindings/display/panel > grep -C20 "This binding is compatible with the simple-panel" * > > You'll find a huge chunk of files which are rather formulaic. It > might make sense to just have one file and a list of panels which are > simple panels? > > > -Doug > > >