From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Date: Mon, 13 Jun 2016 10:38:17 +0900 Message-ID: <575E0E89.40400@samsung.com> References: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> <5758A58D.7050106@samsung.com> <6e24059d-16f3-210a-8dd2-f8dcb89213a1@osg.samsung.com> <5759EF32.5040302@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:55640 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933059AbcFMBiU (ORCPT ); Sun, 12 Jun 2016 21:38:20 -0400 In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas Cc: Javier Martinez Canillas , Linux Kernel , Marc Zyngier , Kukjin Kim , Seung-Woo Kim , "dri-devel@lists.freedesktop.org" , "linux-samsung-soc@vger.kernel.org" , Kyungmin Park , Krzysztof Kozlowski , David Airlie , Joonyoung Shim , "linux-arm-kernel@lists.infradead.org" 2016=EB=85=84 06=EC=9B=94 10=EC=9D=BC 09:24=EC=97=90 Javier Martinez Ca= nillas =EC=9D=B4(=EA=B0=80) =EC=93=B4 =EA=B8=80: > Hello Inki, >=20 > On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae wrote= : >=20 > [snip] >=20 >>> I know that removing .trg_type is enough but I also removed those l= ines >>> because the fields are not used if .trg_type !=3D I80_HW_TRG. So th= ere is >>> no point to leave a set for unused fields. >>> >>> We can latter add those one HW trigger support is fixed for Exynos5= 420. >>> >> >> As of now, I can merge it but I think it would be not reasonable sol= ution because potential problem still exists even we use SW trigger mod= e in default - ie., in case of using HW trigger mode at bootloader, sam= e problem would happen as long as we don't support PSR mode support. >> >=20 > Yes, I understand that the problem will show again if the bootloader > uses HW trigger mode and that we need proper Panel Self Refresh > support but I think that's a separate issue. That's why I said that > those can be addressed for v4.8 but revert to SW trigger for v4.7 as = a > short term fix for the regression. >=20 > In other words, enabling HW trigger mode breaks the display for the > Exynos5420 and Exynos5800 Peach Pi Chromebooks with the shipped > bootloaders (which are probably the most popular Exynos5 devices with > display and mainline support so is likely to affect users). I thought to add PSR support somehow but put me other things to trouble= =2E Anyway, we could support it later so picked it up. Thanks, Inki Dae >=20 > Best regards, > Javier >=20 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Mon, 13 Jun 2016 10:38:17 +0900 Subject: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 In-Reply-To: References: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> <5758A58D.7050106@samsung.com> <6e24059d-16f3-210a-8dd2-f8dcb89213a1@osg.samsung.com> <5759EF32.5040302@samsung.com> Message-ID: <575E0E89.40400@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2016? 06? 10? 09:24? Javier Martinez Canillas ?(?) ? ?: > Hello Inki, > > On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae wrote: > > [snip] > >>> I know that removing .trg_type is enough but I also removed those lines >>> because the fields are not used if .trg_type != I80_HW_TRG. So there is >>> no point to leave a set for unused fields. >>> >>> We can latter add those one HW trigger support is fixed for Exynos5420. >>> >> >> As of now, I can merge it but I think it would be not reasonable solution because potential problem still exists even we use SW trigger mode in default - ie., in case of using HW trigger mode at bootloader, same problem would happen as long as we don't support PSR mode support. >> > > Yes, I understand that the problem will show again if the bootloader > uses HW trigger mode and that we need proper Panel Self Refresh > support but I think that's a separate issue. That's why I said that > those can be addressed for v4.8 but revert to SW trigger for v4.7 as a > short term fix for the regression. > > In other words, enabling HW trigger mode breaks the display for the > Exynos5420 and Exynos5800 Peach Pi Chromebooks with the shipped > bootloaders (which are probably the most popular Exynos5 devices with > display and mainline support so is likely to affect users). I thought to add PSR support somehow but put me other things to trouble. Anyway, we could support it later so picked it up. Thanks, Inki Dae > > Best regards, > Javier > > >