All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Nikolay Borisov <n.borisov.lkml@gmail.com>,
	Kieran Bingham <kieran@ksquared.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments
Date: Mon, 13 Jun 2016 08:18:48 +0200	[thread overview]
Message-ID: <575E5048.6040204@siemens.com> (raw)
In-Reply-To: <1465403312-18254-1-git-send-email-n.borisov.lkml@gmail.com>

On 2016-06-08 18:28, Nikolay Borisov wrote:
> Python doesn't do automatic expansion of paths. In case one passes
> path of the from ~/foo/bar the gdb scripts won't automatically expand
> that and as a result the symbols files won't be loaded. Fix this
> by explicitly expanding all paths which begin with "~"
> 
> Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
> ---
>  scripts/gdb/linux/symbols.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index 9a0f8923f67c..004b0ac7fa72 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -153,7 +153,7 @@ lx-symbols command."""
>              saved_state['breakpoint'].enabled = saved_state['enabled']
>  
>      def invoke(self, arg, from_tty):
> -        self.module_paths = arg.split()
> +        self.module_paths = [os.path.expanduser(p) for p in arg.split()]
>          self.module_paths.append(os.getcwd())
>  
>          # enforce update
> 

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Kieran, will you take this, as you are already preparing other patches?

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2016-06-13  6:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 21:26 [PATCH] scripts/gdb: Add automatic path expansion when loading modules Nikolay Borisov
2016-06-08  9:35 ` Jan Kiszka
2016-06-08 10:09   ` Nikolay Borisov
2016-06-08 10:21     ` Jan Kiszka
2016-06-08 16:28       ` [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments Nikolay Borisov
2016-06-13  6:18         ` Jan Kiszka [this message]
2016-06-13  8:54           ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575E5048.6040204@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=kieran@ksquared.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n.borisov.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.