From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCNtB-0004cs-5Q for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:10:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCNt5-0003Te-De for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:10:32 -0400 Received: from [59.151.112.132] (port=46396 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCNt4-0003Se-Na for qemu-devel@nongnu.org; Mon, 13 Jun 2016 05:10:27 -0400 References: <1465552478-5540-1-git-send-email-caoj.fnst@cn.fujitsu.com> <87h9cxqxtn.fsf@dusky.pond.sub.org> From: Cao jin Message-ID: <575E79CB.8080300@cn.fujitsu.com> Date: Mon, 13 Jun 2016 17:15:55 +0800 MIME-Version: 1.0 In-Reply-To: <87h9cxqxtn.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 00/17] Add param Error ** for msi_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Jason Wang , Marcel Apfelbaum , Alex Williamson , Hannes Reinecke , Dmitry Fleytman , Paolo Bonzini , John Snow , Gerd Hoffmann On 06/13/2016 04:48 PM, Markus Armbruster wrote: > Cao jin writes: > >> v8 changelog: >> 1. address all stylistic remarks (Markus) >> 2. add two new patches(16&17) which I missed in last round, shoot the unnecessary >> internal msi flag. >> 3. rebase on the upstream, fix trivial conflict in vmxnet3: >> -#include "vmxnet_tx_pkt.h" >> -#include "vmxnet_rx_pkt.h" >> +#include "net_tx_pkt.h" >> +#include "net_rx_pkt.h" >> 4. There is a new device "e1000e" added, need to cover it in patch 12. >> >> Hi Markus, I add your R-b in first 15 patches, maybe you want to take a glance >> at e1000e part in patch 12. >> >> The last two new patches need some review. >> Will take care of msix flag cleanup when tackle msix_init(). > > Series > Reviewed-by: Markus Armbruster > Thanks very much. I will send a single patch 16 in-reply-to the current in the series, to fix the stylistic issue. -- Yours Sincerely, Cao jin