From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH] drm: hdlcd: Unwind the DRM setup on error conditions in the right order. Date: Mon, 13 Jun 2016 12:02:31 +0100 Message-ID: <575E92C7.8090107@arm.com> References: <1465390613-15905-1-git-send-email-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id 551136E532 for ; Mon, 13 Jun 2016 11:02:34 +0000 (UTC) In-Reply-To: <1465390613-15905-1-git-send-email-Liviu.Dudau@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau , Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org T24gMDgvMDYvMTYgMTM6NTYsIExpdml1IER1ZGF1IHdyb3RlOgo+IEluIGhkbGNkX2RybV9iaW5k KCkvaGRsY2RfZHJtX3VuYmluZCgpIHdlIHVud2luZCB0aGUgRFJNIHNldHVwIGluIHRoZQo+IHdy b25nIG9yZGVyIChkcm1fbW9kZV9jb25maWdfY2xlYW51cCgpIGJlZm9yZSBjb25uZWN0b3IgYW5k IGVuY29kZXIKPiBoYWQgYSBjaGFuY2UgdG8gY2xlYW51cCB0aGVpciBtZW1vcnkgb3IgYmVmb3Jl IGRybV9kZXZfdW5yZWdpc3RlcigpKS4KPiBUaGUgY29ycmVjdCBvcmRlciBzaG91bGQgbWF0Y2gg aW4gYm90aCBmdW5jdGlvbnMuCj4KPiBSZXBvcnRlZC1ieTogUm9iaW4gTXVycGh5IDxSb2Jpbi5N dXJwaHlAYXJtLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMaXZpdSBEdWRhdSA8TGl2aXUuRHVkYXVA YXJtLmNvbT4KPiAtLS0KPgo+IFJvYmluLAo+Cj4gSSBiZWxpZXZlIHRoaXMgc2hvdWxkIGZpeCB5 b3VyIHByb2JsZW1zIHdpdGggSERMQ0QgZmFpbGluZyB0byBhbGxvY2F0ZSBDTUEKPiBtZW1vcnkg YW5kIHRoZW4gY3Jhc2hpbmcuCgpIZWgsIEknbSBub3Qgc3VyZSBJJ2QgZXZlbiBjbG9ja2VkIHRo YXQgdGhlcmUgd2FzIHlldCBhbm90aGVyIHByb3BibGVtIApiZXlvbmQgdGhlIG9yaWdpbmFsIGdl bV9mcmVlX29iamVjdCgpIGNyYXNoLiBJJ3ZlIGp1c3QgdHJpZWQgNC43LXJjMyAKd2l0aCB0aGUg cmVsZXZhbnQgZml4ZXMgZm9yIHRoYXQsIGFuZCBpbmRlZWQgZHJtX2Nvbm5lY3Rvcl9jbGVhbnVw KCkgCmRvZXMgZ28gYmFuZywgYW5kIHRoaXMgcGF0Y2ggbWFrZXMgaXQgaGFwcHkgYWdhaW4uCgpU ZXN0ZWQtYnk6IFJvYmluIE11cnBoeSA8cm9iaW4ubXVycGh5QGFybS5jb20+CgpUaGFua3MsClJv YmluLgoKPgo+IEJlc3QgcmVnYXJkcywKPiBMaXZpdQo+Cj4gICBkcml2ZXJzL2dwdS9kcm0vYXJt L2hkbGNkX2Rydi5jIHwgOCArKysrLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXJt L2hkbGNkX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9kcnYuYwo+IGluZGV4IDM0 MjJjYTIuLjJjNmVkZGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9k cnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2RfZHJ2LmMKPiBAQCAtMzgyLDcg KzM4Miw2IEBAIHN0YXRpYyBpbnQgaGRsY2RfZHJtX2JpbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ Cj4gICBlcnJfZmJkZXY6Cj4gICAJZHJtX2ttc19oZWxwZXJfcG9sbF9maW5pKGRybSk7Cj4gLQlk cm1fbW9kZV9jb25maWdfY2xlYW51cChkcm0pOwo+ICAgCWRybV92YmxhbmtfY2xlYW51cChkcm0p Owo+ICAgZXJyX3ZibGFuazoKPiAgIAlwbV9ydW50aW1lX2Rpc2FibGUoZHJtLT5kZXYpOwo+IEBA IC0zOTAsNiArMzg5LDcgQEAgZXJyX3BtX2FjdGl2ZToKPiAgIAljb21wb25lbnRfdW5iaW5kX2Fs bChkZXYsIGRybSk7Cj4gICBlcnJfdW5yZWdpc3RlcjoKPiAgIAlkcm1fZGV2X3VucmVnaXN0ZXIo ZHJtKTsKPiArCWRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRybSk7Cj4gICBlcnJfdW5sb2FkOgo+ ICAgCWRybV9pcnFfdW5pbnN0YWxsKGRybSk7Cj4gICAJb2ZfcmVzZXJ2ZWRfbWVtX2RldmljZV9y ZWxlYXNlKGRybS0+ZGV2KTsKPiBAQCAtNDEwLDE1ICs0MTAsMTUgQEAgc3RhdGljIHZvaWQgaGRs Y2RfZHJtX3VuYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gICAJCWhkbGNkLT5mYmRldiA9IE5V TEw7Cj4gICAJfQo+ICAgCWRybV9rbXNfaGVscGVyX3BvbGxfZmluaShkcm0pOwo+IC0JY29tcG9u ZW50X3VuYmluZF9hbGwoZGV2LCBkcm0pOwo+ICAgCWRybV92YmxhbmtfY2xlYW51cChkcm0pOwo+ ICsJY29tcG9uZW50X3VuYmluZF9hbGwoZGV2LCBkcm0pOwo+ICAgCXBtX3J1bnRpbWVfZ2V0X3N5 bmMoZHJtLT5kZXYpOwo+ICAgCWRybV9pcnFfdW5pbnN0YWxsKGRybSk7Cj4gICAJcG1fcnVudGlt ZV9wdXRfc3luYyhkcm0tPmRldik7Cj4gICAJcG1fcnVudGltZV9kaXNhYmxlKGRybS0+ZGV2KTsK PiAtCW9mX3Jlc2VydmVkX21lbV9kZXZpY2VfcmVsZWFzZShkcm0tPmRldik7Cj4gLQlkcm1fbW9k ZV9jb25maWdfY2xlYW51cChkcm0pOwo+ICAgCWRybV9kZXZfdW5yZWdpc3Rlcihkcm0pOwo+ICsJ ZHJtX21vZGVfY29uZmlnX2NsZWFudXAoZHJtKTsKPiArCW9mX3Jlc2VydmVkX21lbV9kZXZpY2Vf cmVsZWFzZShkcm0tPmRldik7Cj4gICAJZHJtX2Rldl91bnJlZihkcm0pOwo+ICAgCWRybS0+ZGV2 X3ByaXZhdGUgPSBOVUxMOwo+ICAgCWRldl9zZXRfZHJ2ZGF0YShkZXYsIE5VTEwpOwo+CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK