From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.85.209 with SMTP id j200csp1155056lfb; Mon, 13 Jun 2016 04:49:00 -0700 (PDT) X-Received: by 10.200.53.39 with SMTP id y36mr13680480qtb.92.1465818540453; Mon, 13 Jun 2016 04:49:00 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b23si14936299qkh.75.2016.06.13.04.49.00 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 13 Jun 2016 04:49:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:55661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQMV-0000J0-Pc for alex.bennee@linaro.org; Mon, 13 Jun 2016 07:48:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQHp-0004Et-5K for qemu-arm@nongnu.org; Mon, 13 Jun 2016 07:44:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCQHo-0005jT-BC for qemu-arm@nongnu.org; Mon, 13 Jun 2016 07:44:09 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:40771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQFO-00052L-2M; Mon, 13 Jun 2016 07:44:01 -0400 Received: from 172.24.1.60 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.1.60]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DMC26167; Mon, 13 Jun 2016 19:40:39 +0800 (CST) Received: from [127.0.0.1] (10.177.16.142) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.235.1; Mon, 13 Jun 2016 19:40:28 +0800 Message-ID: <575E9B3B.5050606@huawei.com> Date: Mon, 13 Jun 2016 19:38:35 +0800 From: Shannon Zhao User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Peter Maydell , , References: <1464274540-19693-1-git-send-email-peter.maydell@linaro.org> <1464274540-19693-20-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1464274540-19693-20-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.575E9BB9.00AA, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e8f7884137b0b66024fe94fe8abb3ed4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 58.251.152.64 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2 19/22] target-arm/machine.c: Allow user to request GICv3 emulation X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@linaro.org, Shlomo Pongratz , Shlomo Pongratz , Pavel Fedin , Shannon Zhao , Christoffer Dall Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: BAKz/cvGqJHa On 2016/5/26 22:55, Peter Maydell wrote: > Now we have an emulated GICv3, remove the restriction in > gicv3_class_name() so that the user can request a GICv3 with > -machine gic-version=3 even when not using KVM. > > Signed-off-by: Peter Maydell Reviewed-by: Shannon Zhao > --- > target-arm/machine.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target-arm/machine.c b/target-arm/machine.c > index 2f45260..2dbeb82 100644 > --- a/target-arm/machine.c > +++ b/target-arm/machine.c > @@ -342,8 +342,7 @@ const char *gicv3_class_name(void) > "platform"); > #endif > } else { > - /* TODO: Software emulation is not implemented yet */ > - error_report("KVM is currently required for GICv3 emulation"); > + return "arm-gicv3"; > } > > exit(1); > -- Shannon From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQHn-00048p-29 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:44:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCQHh-0005iY-8l for qemu-devel@nongnu.org; Mon, 13 Jun 2016 07:44:06 -0400 Message-ID: <575E9B3B.5050606@huawei.com> Date: Mon, 13 Jun 2016 19:38:35 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1464274540-19693-1-git-send-email-peter.maydell@linaro.org> <1464274540-19693-20-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1464274540-19693-20-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 19/22] target-arm/machine.c: Allow user to request GICv3 emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: patches@linaro.org, Shlomo Pongratz , Shlomo Pongratz , Pavel Fedin , Shannon Zhao , Christoffer Dall On 2016/5/26 22:55, Peter Maydell wrote: > Now we have an emulated GICv3, remove the restriction in > gicv3_class_name() so that the user can request a GICv3 with > -machine gic-version=3 even when not using KVM. > > Signed-off-by: Peter Maydell Reviewed-by: Shannon Zhao > --- > target-arm/machine.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target-arm/machine.c b/target-arm/machine.c > index 2f45260..2dbeb82 100644 > --- a/target-arm/machine.c > +++ b/target-arm/machine.c > @@ -342,8 +342,7 @@ const char *gicv3_class_name(void) > "platform"); > #endif > } else { > - /* TODO: Software emulation is not implemented yet */ > - error_report("KVM is currently required for GICv3 emulation"); > + return "arm-gicv3"; > } > > exit(1); > -- Shannon