From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] mbuf: remove unused Rx error flags Date: Mon, 13 Jun 2016 13:39:33 +0200 Message-ID: <575E9B75.5070902@6wind.com> References: <57344C06.1030007@6wind.com> <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: johndale@cisco.com, konstantin.ananyev@intel.com, helin.zhang@intel.com, arnon@qwilt.com, rolette@infinite.io, jing.d.chen@intel.com, jingjing.wu@intel.com To: dev@dpdk.org Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id D2CC72BD5 for ; Mon, 13 Jun 2016 13:39:44 +0200 (CEST) In-Reply-To: <1463990171-10295-1-git-send-email-olivier.matz@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 05/23/2016 09:56 AM, Olivier Matz wrote: > Following the discussions from: > http://dpdk.org/ml/archives/dev/2015-July/021721.html > http://dpdk.org/ml/archives/dev/2016-April/038143.html > > The value of these flags is 0, making them useless. Today, no example > application checks them on Rx, and only few drivers sets them and > silently give wrong packets to the application, which should not happen. > > This patch removes the unused flags from rte_mbuf and their use in the > drivers. The i40e and fm10k are kept as they are today and should be > fixed to drop bad packets. The enic driver is managed by its maintainer > in another patch. > > Fixes: c22265f6 ("mbuf: add new packet flags for i40e") > Signed-off-by: Olivier Matz Any comment from someone?