From: Remy Horton <remy.horton@intel.com>
To: Zyta Szpak <zr@semihalf.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 1/2] ethdev: add callback to get register size in bytes
Date: Mon, 13 Jun 2016 16:51:02 +0100 [thread overview]
Message-ID: <575ED666.2010509@intel.com> (raw)
In-Reply-To: <CA+E8-F0KdYROi7KkXmf_zjR+Y68oZAjqq0GFRKJUt_Uqowe7-w@mail.gmail.com>
On 12/06/2016 15:51, Zyta Szpak wrote:
> I would prefer having only one function rte_eth_dev_get_regs()
> which returns length and width if data is NULL.
> The first call is a parameter request before buffer allocation,
> and the second call fills the buffer.
>
> We can deprecate the old API and introduce this new one.
>
> Opinions?
>
> In my opinion as it is now it works fine. Gathering all parameters in
> one callback might be a good idea if the maintainer also agrees to that
> because as I mentioned, it interferes.
From my perspective changing rte_eth_dev_get_regs() isn't a problem, as
it isn't used directly rather than through rte_ethtool_get_regs()..
..Remy
next prev parent reply other threads:[~2016-06-13 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 7:56 [PATCH v3 1/2] ethdev: add callback to get register size in bytes zr
2016-06-01 7:56 ` [PATCH v3 2/2] examples/ethtool: get reg width to allocate memory zr
2016-06-07 9:52 ` Remy Horton
2016-06-07 9:52 ` [PATCH v3 1/2] ethdev: add callback to get register size in bytes Remy Horton
2016-06-08 8:53 ` Thomas Monjalon
2016-06-12 14:51 ` Zyta Szpak
2016-06-13 15:51 ` Remy Horton [this message]
2016-06-17 10:20 ` Thomas Monjalon
2016-06-21 9:55 ` Zyta Szpak
2016-06-22 8:19 ` Zyta Szpak
2016-06-22 8:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575ED666.2010509@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.