Re: [Qemu-devel] [PATCH 1/6] doc: move text describing --trace to specific .texi file

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> This text will be included to qemu-nbd/qemu-img mans in the next patches.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---

> +++ b/qemu-option-trace.texi
> @@ -0,0 +1,27 @@
> +@findex -trace
> +

I think the @findex entry should remain per-file, and not in the include
(since the other executables will spell it '--trace', and only qemu
proper accepts the shorthand '-trace').

> +++ b/qemu-options.hx
> @@ -3661,33 +3661,7 @@ STEXI
>  HXCOMM This line is not accurate, as some sub-options are backend-specific but
>  HXCOMM HX does not support conditional compilation of text.
>  @item -trace [events=@var{file}][,file=@var{file}]
> -@findex -trace

Otherwise, it looks fine to me.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]