Re: [PATCH v2 1/4] PCI: Unexport of_pci_parse_bus_range()

[Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>]

Hi,

On 1/13/25 3:15 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> of_pci_parse_bus_range() is only used in drivers/pci/of.c, so make it
> static and unexport it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
Looks good

Reviewed-by: Kuppuswamy Sathyanarayanan 
<sathyanarayanan.kuppuswamy@linux.intel.com>

>   drivers/pci/of.c  | 4 ++--
>   drivers/pci/pci.h | 7 -------
>   2 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 52f770bcc481..2f579b691f8e 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -190,7 +190,8 @@ EXPORT_SYMBOL_GPL(of_pci_get_devfn);
>    *
>    * Returns 0 on success or a negative error-code on failure.
>    */
> -int of_pci_parse_bus_range(struct device_node *node, struct resource *res)
> +static int of_pci_parse_bus_range(struct device_node *node,
> +				  struct resource *res)
>   {
>   	u32 bus_range[2];
>   	int error;
> @@ -207,7 +208,6 @@ int of_pci_parse_bus_range(struct device_node *node, struct resource *res)
>   
>   	return 0;
>   }
> -EXPORT_SYMBOL_GPL(of_pci_parse_bus_range);
>   
>   /**
>    * of_get_pci_domain_nr - Find the host bridge domain number
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 2e40fc63ba31..35faf4770a14 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -797,7 +797,6 @@ static inline u64 pci_rebar_size_to_bytes(int size)
>   struct device_node;
>   
>   #ifdef CONFIG_OF
> -int of_pci_parse_bus_range(struct device_node *node, struct resource *res);
>   int of_get_pci_domain_nr(struct device_node *node);
>   int of_pci_get_max_link_speed(struct device_node *node);
>   u32 of_pci_get_slot_power_limit(struct device_node *node,
> @@ -813,12 +812,6 @@ int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge);
>   bool of_pci_supply_present(struct device_node *np);
>   
>   #else
> -static inline int
> -of_pci_parse_bus_range(struct device_node *node, struct resource *res)
> -{
> -	return -EINVAL;
> -}
> -
>   static inline int
>   of_get_pci_domain_nr(struct device_node *node)
>   {

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer