From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jorge Ramirez Subject: Re: [PATCH v5 2/2] mtd: mediatek: driver for MTK Smart Device Date: Tue, 14 Jun 2016 13:35:25 -0400 Message-ID: <5760405D.3090101@linaro.org> References: <1465919451-1891-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1465919451-1891-3-git-send-email-jorge.ramirez-ortiz@linaro.org> <20160614184433.2b399c8b@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160614184433.2b399c8b@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Boris Brezillon , xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On 06/14/2016 12:44 PM, Boris Brezillon wrote: > Apart from a few coding style issues that I can fix when applying the > patch it looks good to me. thanks Boris for the all the reviews. and apologies for having taking this long for posting v5 (the US immigration system has been fun to deal with..actually there are not 9 but 10 circles of hell) > If I understand correctly, you don't have access to the hardware > anymore. Xiolei (or anyone else owning the proper hardware), can you add > your Tested-by? > > Thanks, > > Boris From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bCsFh-0006Xv-Po for linux-mtd@lists.infradead.org; Tue, 14 Jun 2016 17:35:51 +0000 Received: by mail-qk0-x230.google.com with SMTP id c73so66617198qkg.2 for ; Tue, 14 Jun 2016 10:35:29 -0700 (PDT) Subject: Re: [PATCH v5 2/2] mtd: mediatek: driver for MTK Smart Device To: Boris Brezillon , xiaolei.li@mediatek.com References: <1465919451-1891-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1465919451-1891-3-git-send-email-jorge.ramirez-ortiz@linaro.org> <20160614184433.2b399c8b@bbrezillon> Cc: robh@kernel.org, computersforpeace@gmail.com, daniel.thompson@linaro.org, erin.lo@mediatek.com, linux-mtd@lists.infradead.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, dwmw2@infradead.org, blogic@openwrt.org From: Jorge Ramirez Message-ID: <5760405D.3090101@linaro.org> Date: Tue, 14 Jun 2016 13:35:25 -0400 MIME-Version: 1.0 In-Reply-To: <20160614184433.2b399c8b@bbrezillon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/14/2016 12:44 PM, Boris Brezillon wrote: > Apart from a few coding style issues that I can fix when applying the > patch it looks good to me. thanks Boris for the all the reviews. and apologies for having taking this long for posting v5 (the US immigration system has been fun to deal with..actually there are not 9 but 10 circles of hell) > If I understand correctly, you don't have access to the hardware > anymore. Xiolei (or anyone else owning the proper hardware), can you add > your Tested-by? > > Thanks, > > Boris