From: Jeremy Linton <jeremy.linton@arm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, steve.glendinning@shawell.net
Subject: Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL
Date: Tue, 14 Jun 2016 15:48:50 -0500 [thread overview]
Message-ID: <57606DB2.5030602@arm.com> (raw)
In-Reply-To: <20160614184236.GB8518@lunn.ch>
On 06/14/2016 01:42 PM, Andrew Lunn wrote:
> On Tue, Jun 14, 2016 at 11:16:02AM -0500, Jeremy Linton wrote:
>> If the interrupt configuration isn't set and we are using the
>> internal phy, then we need to poll the phy to reliably detect
>> phy state changes.
>
> Hi Jeremy
> Why does the external phy not have the exact same problem?
Hello,
It may... but I've only got a fairly limited hardware testing setup, and
this driver is used across a pretty broad set of hardware configured in
various ways. So, I'm trying to limit the scope of things I might break.
Initially I thought it was added to avoid a QEMU issue, but now I don't
think that is the case.
So, if 0 can't be an interrupt why not update phy_interrupt_is_valid()
to check for it? That would fix the problem too...
next prev parent reply other threads:[~2016-06-14 20:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 16:16 [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL Jeremy Linton
2016-06-14 18:30 ` Sergei Shtylyov
2016-06-14 19:27 ` Sergei Shtylyov
2016-06-14 19:49 ` Sergei Shtylyov
2016-06-14 20:12 ` Andrew Lunn
2016-06-14 20:21 ` Sergei Shtylyov
2016-06-14 20:13 ` Jeremy Linton
2016-06-14 18:42 ` Andrew Lunn
2016-06-14 20:48 ` Jeremy Linton [this message]
2016-06-14 20:44 ` Sergei Shtylyov
2016-06-14 20:59 ` Jeremy Linton
2016-06-14 21:24 ` Sergei Shtylyov
2016-06-14 22:26 ` Andrew Lunn
2016-06-15 15:50 ` Jeremy Linton
2016-06-14 21:02 ` Jeremy Linton
2016-06-14 21:12 ` Jeremy Linton
2016-06-14 21:26 ` Sergei Shtylyov
2016-06-14 21:29 ` Jeremy Linton
2016-06-14 21:34 ` Sergei Shtylyov
2016-06-14 21:40 ` Jeremy Linton
2016-06-14 21:42 ` Sergei Shtylyov
2016-06-14 21:53 ` Jeremy Linton
2016-06-14 21:56 ` Sergei Shtylyov
2016-06-15 15:56 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57606DB2.5030602@arm.com \
--to=jeremy.linton@arm.com \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.