From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH] xen/arm: map_dev_mmio_region: The iomem permission check should be done on MFN Date: Wed, 15 Jun 2016 09:43:25 +0800 Message-ID: <5760B2BD.8090804@huawei.com> References: <1465905026-12887-1-git-send-email-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1465905026-12887-1-git-send-email-julien.grall@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, Shannon Zhao List-Id: xen-devel@lists.xenproject.org SGkgSnVsaWVuLAoKT24gMjAxNi82LzE0IDE5OjUwLCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gVGhl IGhlbHBlciBpb21lbV9hY2Nlc3NfcGVybWl0dGVkIGV4cGVjdHMgTUZOcyBpbiBwYXJhbWV0ZXJz IGFuZCBub3QKPiBHTkZzLiBUaGFua2Z1bGx5IG9ubHkgdGhlIGhhcmR3YXJlIGRvbWFpbiBjYW4g Y2FsbCB0aGlzIGZ1bmN0aW9uIGFuZAo+IGl0IHdpbGwgYWx3YXlzIGJlIHdpdGggR0ZOUyA9PSBN Rk5zIGZvciBub3cuCj4gCj4gQWxzbywgZml4IHRoZSBwcmludGYgdG8gdXNlIHRoZSBNRk4gcmFu Z2UgYW5kIG5vdCB0aGUgR0ZOIG9uZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwg PGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IENjOiBTaGFubm9uIFpoYW8gPHNoYW5ub24uemhhb0Bs aW5hcm8ub3JnPgo+IApSZXZpZXdlZC1ieTogU2hhbm5vbiBaaGFvIDxzaGFubm9uLnpoYW9AbGlu YXJvLm9yZz4KCj4gLS0tCj4gICAgIFRoaXMgcGF0Y2ggaXMgYSBnb29kIGNhbmRpZGF0ZSB0byBi YWNrcG9ydCB0byBYZW4gNC43LiBXaXRob3V0Cj4gICAgIGl0LCB0aGUgaGFyZHdhcmUgZG9tYWlu IGNhbiBtYXAgYW55IE1NSU8gYmVjYXVzZSB0aGUgcGVybWlzc2lvbgo+ICAgICBjaGVjayBpcyBk b25lIG9uIHRoZSBHUEZOcyBhbmQgbm90IHRoZSBNTkZzLgo+IC0tLQo+ICB4ZW4vYXJjaC9hcm0v cDJtLmMgfCA0ICsrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gv YXJtL3AybS5jCj4gaW5kZXggNmExOWM1Ny4uNGM2NTQ3ZCAxMDA2NDQKPiAtLS0gYS94ZW4vYXJj aC9hcm0vcDJtLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vcDJtLmMKPiBAQCAtMTI3NSwxNCArMTI3 NSwxNCBAQCBpbnQgbWFwX2Rldl9tbWlvX3JlZ2lvbihzdHJ1Y3QgZG9tYWluICpkLAo+ICB7Cj4g ICAgICBpbnQgcmVzOwo+ICAKPiAtICAgIGlmICggIShuciAmJiBpb21lbV9hY2Nlc3NfcGVybWl0 dGVkKGQsIHN0YXJ0X2dmbiwgc3RhcnRfZ2ZuICsgbnIgLSAxKSkgKQo+ICsgICAgaWYgKCAhKG5y ICYmIGlvbWVtX2FjY2Vzc19wZXJtaXR0ZWQoZCwgbWZuLCBtZm4gKyBuciAtIDEpKSApCj4gICAg ICAgICAgcmV0dXJuIDA7Cj4gIAo+ICAgICAgcmVzID0gbWFwX21taW9fcmVnaW9ucyhkLCBzdGFy dF9nZm4sIG5yLCBtZm4pOwo+ICAgICAgaWYgKCByZXMgPCAwICkKPiAgICAgIHsKPiAgICAgICAg ICBwcmludGsoWEVOTE9HX0dfRVJSICJVbmFibGUgdG8gbWFwIFslI2x4IC0gJSNseF0gaW4gRG9t JWRcbiIsCj4gLSAgICAgICAgICAgICAgIHN0YXJ0X2dmbiwgc3RhcnRfZ2ZuICsgbnIgLSAxLCBk LT5kb21haW5faWQpOwo+ICsgICAgICAgICAgICAgICBtZm4sIG1mbiArIG5yIC0gMSwgZC0+ZG9t YWluX2lkKTsKPiAgICAgICAgICByZXR1cm4gcmVzOwo+ICAgICAgfQo+ICAKPiAKCi0tIApTaGFu bm9uCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMu eGVuLm9yZy94ZW4tZGV2ZWwK