From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v3 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support Date: Wed, 15 Jun 2016 09:56:14 +0800 Message-ID: <5760B5BE.8020908@rock-chips.com> References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904780-935-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson Cc: Krzysztof Kozlowski , linux-samsung-soc , "open list:ARM/Rockchip SoC..." , Mark Yao , Jingoo Han , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Javier Martinez Canillas , Daniel Vetter , Tomasz Figa , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Thierry Reding , Dan Carpenter List-Id: linux-rockchip.vger.kernel.org RG91ZywKCk9uIDA2LzE0LzIwMTYgMTE6MjQgUE0sIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4gWWFr aXIsCj4KPiBPbiBUdWUsIEp1biAxNCwgMjAxNiBhdCA0OjQ2IEFNLCBZYWtpciBZYW5nIDx5a2tA cm9jay1jaGlwcy5jb20+IHdyb3RlOgo+PiBSSzMzOTkgYW5kIFJLMzI4OCBzaGFyZWQgdGhlIHNh bWUgZURQIElQIGNvbnRyb2xsZXIsIG9ubHkgc29tZSBsaWdodAo+PiBkaWZmZXJlbmNlIHdpdGgg Vk9QIGNvbmZpZ3VyZSBhbmQgR1JGIGNvbmZpZ3VyZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogWWFr aXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPgo+PiBBY2tlZC1ieTogTWFyayBZYW8gPG1hcmsu eWFvQHJvY2stY2hpcHMuY29tPgo+PiAtLS0KPj4gQ2hhbmdlcyBpbiB2MzoKPj4gLSBHaXZlIHRo ZSAicmszMzk5LWVkcCIgYSBzZXBhcmF0ZSBsaW5lIGZvciBjbGFyaXR5IGluIGRvY3VtZW50IChU b21hc3osIHJldmlld2VkIGF0IEdvb2dsZSBHZXJyaXQpCj4+ICAgICAgW2h0dHBzOi8vY2hyb21p dW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20vIy9jLzM0NjMxNC8xMC9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC50 eHRANV0KPj4gLSBNb3ZlICdvdXRwdXRfdHlwZScgc2V0dGluZyBiZWZvcmUgdGhlIHJldHVybiBz dGF0ZW1lbnQgKFRvbWFzeiwgcmV2aWV3ZWQgYXQgR29vZ2xlIEdlcnJpdCkKPj4gICAgICBbaHR0 cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS8jL2MvMzQ2MzE0LzEwL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC5jQDE1NF0KPj4gLSBBZGQg dGhlIGFja2VkIGZsYWcgZnJvbSBNYXJrLgo+Pgo+PiBDaGFuZ2VzIGluIHYyOgo+PiAtIHJlYmFz ZSB3aXRoIGRybS1uZXh0LCBmaXggc29tZSBjb25mbGljdHMKPj4KPj4gICAuLi4vYmluZGluZ3Mv ZGlzcGxheS9icmlkZ2UvYW5hbG9naXhfZHAudHh0ICAgICAgICB8ICAxICsKPj4gICAuLi4vZGlz cGxheS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC50eHQgICAgICB8ICAzICstCj4+ICAg ZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLmMgICAgfCAzMyAr KysrKysrKysrKysrKysrKysrKystCj4+ICAgaW5jbHVkZS9kcm0vYnJpZGdlL2FuYWxvZ2l4X2Rw LmggICAgICAgICAgICAgICAgICAgfCAgMSArCj4+ICAgNCBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4dCBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9hbmFsb2dpeF9k cC50eHQKPj4gaW5kZXggNGYyYmE4Yy4uNGEwZjRmNyAxMDA2NDQKPj4gLS0tIGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4dAo+ PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2Uv YW5hbG9naXhfZHAudHh0Cj4+IEBAIC01LDYgKzUsNyBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzIGZv ciBkcC1jb250cm9sbGVyOgo+PiAgICAgICAgICAgICAgICAgIHBsYXRmb3JtIHNwZWNpZmljIHN1 Y2ggYXM6Cj4+ICAgICAgICAgICAgICAgICAgICogInNhbXN1bmcsZXh5bm9zNS1kcCIKPj4gICAg ICAgICAgICAgICAgICAgKiAicm9ja2NoaXAscmszMjg4LWRwIgo+PiArICAgICAgICAgICAgICAg ICogInJvY2tjaGlwLHJrMzM5OS1lZHAiCj4+ICAgICAgICAgIC1yZWc6Cj4+ICAgICAgICAgICAg ICAgICAgcGh5c2ljYWwgYmFzZSBhZGRyZXNzIG9mIHRoZSBjb250cm9sbGVyIGFuZCBsZW5ndGgK Pj4gICAgICAgICAgICAgICAgICBvZiBtZW1vcnkgbWFwcGVkIHJlZ2lvbi4KPj4gZGlmZiAtLWdp dCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2Fu YWxvZ2l4X2RwLXJvY2tjaGlwLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9kaXNwbGF5L3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLnR4dAo+PiBpbmRleCBlODMy ZmY5Li43MjZjOTQ1IDEwMDY0NAo+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC50eHQKPj4gKysrIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvYW5hbG9n aXhfZHAtcm9ja2NoaXAudHh0Cj4+IEBAIC0yLDcgKzIsOCBAQCBSb2NrY2hpcCBSSzMyODggc3Bl Y2lmaWMgZXh0ZW5zaW9ucyB0byB0aGUgQW5hbG9naXggRGlzcGxheSBQb3J0Cj4+ICAgPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KPj4KPj4gICBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ PiAtLSBjb21wYXRpYmxlOiAicm9ja2NoaXAscmszMjg4LWVkcCI7Cj4+ICstIGNvbXBhdGlibGU6 ICJyb2NrY2hpcCxyazMyODgtZWRwIiwKPj4gKyAgICAgICAgICAgICAicm9ja2NoaXAscmszMzk5 LWVkcCI7Cj4gQXMgY29tbWVudGVkIGJ5IFRvbWFzeiBvbiBnZXJyaXQsIHRoZXJlIGlzIGEgcHJl LWV4aXN0aW5nIHR5cG8gaGVyZS4KPiBTcGVjaWZpY2FsbHkgInJvY2tjaGlwLHJrMzI4OC1lZHAi IHNob3VsZCBiZSAicm9ja2NoaXAscmszMjg4LWRwIi4KPgo+IFRoZSB0eXBvIGlzIHByZS1leGlz dGluZyBzbyBJJ20gbm90IHN1cmUgeW91IHdvdWxkIG5lZWQgdG8gc3BpbiB0aGlzCj4gc2VyaWVz IHRvIGZpeCBpdCwgYnV0IGlmIHlvdSB3ZXJlIHNwaW5uaW5nIGl0IGFueXdheSBpdCB3b3VsZG4n dCBodXJ0Cj4gdG8gZml4LiAgQ291bGQgYWxzbyBqdXN0IHNlbmQgb3V0IGEgZm9sbG93b24gcGF0 Y2ggdG8gZml4IHRoaXMgYWZ0ZXIKPiB0aGUgc2VyaWVzIGxhbmRzLi4uCgpNeSBiYWQsIGZvcmdl dCB0byBmaXggdGhhdCA6KAppdCB3b3VsZCBiZSBiZXR0ZXIgdG8gbWVyZ2UgdGhhdCBmaXggaW50 byB0aGlzIHNlcmllcywgd291bGQgc2VuZCBhIApmb2xsb3cgcGF0Y2ggc29vbi4KClRoYW5rcyBm b3IgcmVtaW5kaW5nLAotIFlha2lyCgo+IC1Eb3VnCj4KPgo+CgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932226AbcFOB40 (ORCPT ); Tue, 14 Jun 2016 21:56:26 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:47137 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbcFOB4Y (ORCPT ); Tue, 14 Jun 2016 21:56:24 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <0951047c2874aba3c64b417452be2f28> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support To: Doug Anderson References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <1465904780-935-1-git-send-email-ykk@rock-chips.com> Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , David Airlie , Daniel Vetter , Thierry Reding , Krzysztof Kozlowski , Emil Velikov , Dan Carpenter , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , linux-samsung-soc , "open list:ARM/Rockchip SoC..." From: Yakir Yang Message-ID: <5760B5BE.8020908@rock-chips.com> Date: Wed, 15 Jun 2016 09:56:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, On 06/14/2016 11:24 PM, Doug Anderson wrote: > Yakir, > > On Tue, Jun 14, 2016 at 4:46 AM, Yakir Yang wrote: >> RK3399 and RK3288 shared the same eDP IP controller, only some light >> difference with VOP configure and GRF configure. >> >> Signed-off-by: Yakir Yang >> Acked-by: Mark Yao >> --- >> Changes in v3: >> - Give the "rk3399-edp" a separate line for clarity in document (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346314/10/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt@5] >> - Move 'output_type' setting before the return statement (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346314/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@154] >> - Add the acked flag from Mark. >> >> Changes in v2: >> - rebase with drm-next, fix some conflicts >> >> .../bindings/display/bridge/analogix_dp.txt | 1 + >> .../display/rockchip/analogix_dp-rockchip.txt | 3 +- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 33 +++++++++++++++++++++- >> include/drm/bridge/analogix_dp.h | 1 + >> 4 files changed, 36 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> index 4f2ba8c..4a0f4f7 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> @@ -5,6 +5,7 @@ Required properties for dp-controller: >> platform specific such as: >> * "samsung,exynos5-dp" >> * "rockchip,rk3288-dp" >> + * "rockchip,rk3399-edp" >> -reg: >> physical base address of the controller and length >> of memory mapped region. >> diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> index e832ff9..726c945 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> @@ -2,7 +2,8 @@ Rockchip RK3288 specific extensions to the Analogix Display Port >> ================================ >> >> Required properties: >> -- compatible: "rockchip,rk3288-edp"; >> +- compatible: "rockchip,rk3288-edp", >> + "rockchip,rk3399-edp"; > As commented by Tomasz on gerrit, there is a pre-existing typo here. > Specifically "rockchip,rk3288-edp" should be "rockchip,rk3288-dp". > > The typo is pre-existing so I'm not sure you would need to spin this > series to fix it, but if you were spinning it anyway it wouldn't hurt > to fix. Could also just send out a followon patch to fix this after > the series lands... My bad, forget to fix that :( it would be better to merge that fix into this series, would send a follow patch soon. Thanks for reminding, - Yakir > -Doug > > >