From: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
To: fstests@vger.kernel.org
Cc: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
Subject: Re: [PATCH v2] shared: regression test for hang when processing corrupted orphaned inode list
Date: Wed, 15 Jun 2016 11:43:24 +0800 [thread overview]
Message-ID: <5760CEDC.20202@cn.fujitsu.com> (raw)
In-Reply-To: <20160615033537.GV5140@eguan.usersys.redhat.com>
Hi, Eryu.
Thanks for your review and kindly reply!
On 06/15/2016 11:35 AM, Eryu Guan wrote:
> On Tue, Jun 14, 2016 at 12:39:42PM +0800, Eryu Guan wrote:
>> On Tue, Jun 14, 2016 at 10:58:59AM +0800, Guangwen Feng wrote:
>>> Commit c9eb13a fixed this bug:
>>> ext4: fix hang when processing corrupted orphaned inode list
>>>
>>> Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
>>
>> Looks good to me overall. Some minor issues inline below
>>
> [snip]
>>
>>> + debugfs -w -R "ssv last_orphan $i" $SCRATCH_DEV >>$seqres.full 2>&1
>>
>> You defined $DEBUGFS_PROG, use it here :)
>>
>>> + _scratch_mount
>>> + _scratch_unmount
>>
>> There's a new helper to do this now, _scratch_cycle_mount
>
> Sorry, the helper doesn't help here, it umount first then mount. You're
> doing mount then umount.
Got it.
I was just writing to explain this actually. :)
Thanks again.
>
> Thanks,
> Eryu
>
>
>
next prev parent reply other threads:[~2016-06-15 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:09 [PATCH] ext4: regression test for hang when processing corrupted orphaned inode list Guangwen Feng
2016-06-13 9:33 ` Eryu Guan
2016-06-13 10:15 ` Guangwen Feng
2016-06-14 2:31 ` Guangwen Feng
2016-06-14 2:58 ` [PATCH v2] shared: " Guangwen Feng
2016-06-14 4:39 ` Eryu Guan
2016-06-15 3:35 ` Eryu Guan
2016-06-15 3:43 ` Guangwen Feng [this message]
2016-06-15 5:21 ` [PATCH v3] " Guangwen Feng
2016-06-15 22:55 ` Dave Chinner
2016-06-16 3:41 ` [PATCH v4] " Guangwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5760CEDC.20202@cn.fujitsu.com \
--to=fenggw-fnst@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.