From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT] regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed
Date: Wed, 15 Jun 2016 09:27:32 +0100 [thread overview]
Message-ID: <57611174.4060003@linaro.org> (raw)
In-Reply-To: <1465957294.8494.1.camel@ingics.com>
Hi Mark,
On 15/06/16 03:21, Axel Lin wrote:
> Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is
> wrong because it is used for fixed regulator without any linear range.
> The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV
> set and n_voltages = 1. In this case, regulator_list_voltage() can return
> rdev->desc->fixed_uV without .list_voltage implementation.
>
> Fixes: 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback")
TBH, 3bfbb4d1a480 patch was never in the mailing list, am sure there is
some confusion while applying other patches.
May be a8a47540ebe3 got re-applied, without any errors/warning I guess.
These are the only 2 patches which were submitted in mailing list and
which made into next.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a8a47540ebe32f1733eebc3e5699af580ceaa3f5
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d1e44b6b2823f1751ffe7e7589f545f05cfe2095
Thanks,
srini
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 526bf23..6c7fe477 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -152,7 +152,6 @@ static const struct regulator_ops rpm_smps_ldo_ops_fixed = {
> .enable = rpm_reg_enable,
> .disable = rpm_reg_disable,
> .is_enabled = rpm_reg_is_enabled,
> - .list_voltage = regulator_list_voltage_linear_range,
>
> .get_voltage = rpm_reg_get_voltage,
> .set_voltage = rpm_reg_set_voltage,
>
next prev parent reply other threads:[~2016-06-15 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 2:21 [PATCH RFT] regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed Axel Lin
2016-06-15 8:27 ` Srinivas Kandagatla [this message]
2016-06-15 9:32 ` Applied "regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57611174.4060003@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.