All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew F. Davis" <afd@ti.com>
To: Suman Anna <s-anna@ti.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] reset: add a SYSCON based reset driver
Date: Wed, 15 Jun 2016 11:52:23 -0500	[thread overview]
Message-ID: <576187C7.3020901@ti.com> (raw)
In-Reply-To: <57618775.3000903@ti.com>

On 06/15/2016 11:51 AM, Suman Anna wrote:
> Hi Andrew,
> 
> On 06/01/2016 01:41 PM, Andrew F. Davis wrote:
>> Add a reset-controller driver for performing reset management of
>> various devices present on the SoC, with the reset registers shared
>> between devices in a common register memory space. This driver uses
>> the syscon/regmap frameworks to actually implement the various reset
>> functionalities needed by the reset consumer devices.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> [s-anna@ti.com: add documentation, syscon name change]
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>  drivers/reset/Kconfig        |  10 ++
>>  drivers/reset/Makefile       |   1 +
>>  drivers/reset/reset-syscon.c | 289 +++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 300 insertions(+)
>>  create mode 100644 drivers/reset/reset-syscon.c
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 0b2733d..73072e2 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -15,5 +15,15 @@ menuconfig RESET_CONTROLLER
>>  config RESET_OXNAS
>>  	bool
>>  
>> +config SYSCON_RESET
>> +	tristate "SYSCON Reset Driver"
>> +	depends on RESET_CONTROLLER
> 
> Please add a depends on HAS_IOMEM here that you seem to have missed from
> our local patches.
> 

Will add for v4.

Thanks,
Andrew

WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Suman Anna <s-anna@ti.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] reset: add a SYSCON based reset driver
Date: Wed, 15 Jun 2016 11:52:23 -0500	[thread overview]
Message-ID: <576187C7.3020901@ti.com> (raw)
In-Reply-To: <57618775.3000903@ti.com>

On 06/15/2016 11:51 AM, Suman Anna wrote:
> Hi Andrew,
> 
> On 06/01/2016 01:41 PM, Andrew F. Davis wrote:
>> Add a reset-controller driver for performing reset management of
>> various devices present on the SoC, with the reset registers shared
>> between devices in a common register memory space. This driver uses
>> the syscon/regmap frameworks to actually implement the various reset
>> functionalities needed by the reset consumer devices.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> [s-anna@ti.com: add documentation, syscon name change]
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>  drivers/reset/Kconfig        |  10 ++
>>  drivers/reset/Makefile       |   1 +
>>  drivers/reset/reset-syscon.c | 289 +++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 300 insertions(+)
>>  create mode 100644 drivers/reset/reset-syscon.c
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 0b2733d..73072e2 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -15,5 +15,15 @@ menuconfig RESET_CONTROLLER
>>  config RESET_OXNAS
>>  	bool
>>  
>> +config SYSCON_RESET
>> +	tristate "SYSCON Reset Driver"
>> +	depends on RESET_CONTROLLER
> 
> Please add a depends on HAS_IOMEM here that you seem to have missed from
> our local patches.
> 

Will add for v4.

Thanks,
Andrew

  reply	other threads:[~2016-06-15 16:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 18:41 [PATCH v3 0/2] Add support for SYSCON reset Andrew F. Davis
2016-06-01 18:41 ` Andrew F. Davis
2016-06-01 18:41 ` [PATCH v3 1/2] Documentation: dt: reset: Add syscon reset binding Andrew F. Davis
2016-06-01 18:41   ` Andrew F. Davis
     [not found] ` <20160601184125.20241-1-afd-l0cyMroinI0@public.gmane.org>
2016-06-01 18:41   ` [PATCH v3 2/2] reset: add a SYSCON based reset driver Andrew F. Davis
2016-06-01 18:41     ` Andrew F. Davis
2016-06-15 16:51     ` Suman Anna
2016-06-15 16:51       ` Suman Anna
2016-06-15 16:52       ` Andrew F. Davis [this message]
2016-06-15 16:52         ` Andrew F. Davis
2016-06-15 15:48 ` [PATCH v3 0/2] Add support for SYSCON reset Andrew F. Davis
2016-06-15 15:48   ` Andrew F. Davis
2016-06-15 16:45   ` Philipp Zabel
2016-06-16  2:13     ` Rob Herring
     [not found]       ` <CAL_JsqKL+njqxTUB3MPgX=qJK72bmXXWH4gOuYMC2NFg5u7eqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-20 18:44         ` Andrew F. Davis
2016-06-20 18:44           ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576187C7.3020901@ti.com \
    --to=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.