From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] new ltp lib doesn't print actual error
Date: Wed, 15 Jun 2016 20:08:11 +0300 [thread overview]
Message-ID: <57618B7B.9070402@oracle.com> (raw)
Hi,
When running a test with the new LTP lib, noticed that if some error
occurs in a library (tst_tmpdir.c), it'll print the same message:
TMPDIR=/usr ./creat01
tst_tmpdir.c:155: BROK: Non-NULL cleanup in newlib!
but should be:
TMPDIR=/usr ./creat01
tst_tmpdir.c:155: BROK: tst_tmpdir: mkdtemp(/usr/creF5DhMS) failed: EACCES
May be we should remove the strict check in tst_res.c? Otherwise we
don't see the actual error.
diff --git a/lib/tst_res.c b/lib/tst_res.c
index b388d0d..dd27c54 100644
--- a/lib/tst_res.c
+++ b/lib/tst_res.c
@@ -547,11 +547,6 @@ void tst_brkm_(const char *file, const int lineno,
int ttype,
EXPAND_VAR_ARGS(tmesg, arg_fmt, USERMESG);
if (tst_test) {
- if (func) {
- tst_brk_(file, lineno, TBROK,
- "Non-NULL cleanup in newlib!");
- }
-
tst_brk_(file, lineno, ttype, "%s", tmesg);
} else {
tst_brk__(file, lineno, ttype, func, "%s", tmesg);
Thanks,
Alexey
next reply other threads:[~2016-06-15 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 17:08 Alexey Kodanev [this message]
2016-06-15 17:28 ` [LTP] new ltp lib doesn't print actual error Jan Stancek
2016-06-16 8:46 ` Alexey Kodanev
2016-06-20 12:17 ` Cyril Hrubis
2016-06-20 15:58 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57618B7B.9070402@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.