From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEO6-00037c-V6 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 13:14:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDENw-0003S9-W9 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 13:13:58 -0400 Received: from mout.web.de ([212.227.17.12]:60629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDENw-0003RY-K7 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 13:13:48 -0400 References: <1465993312-18119-1-git-send-email-davidkiarie4@gmail.com> <20160615142648.GG18662@thinpad.lan.raisama.net> From: Jan Kiszka Message-ID: <57618CC1.9000505@web.de> Date: Wed, 15 Jun 2016 19:13:37 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8UcGProwGfSRknhIRcWb5gKNdqvmwCT8O" Subject: Re: [Qemu-devel] [V12 0/4] AMD IOMMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie , Eduardo Habkost Cc: QEMU Developers , Marcel Apfelbaum , "Michael S. Tsirkin" , Peter Xu , alex.williamson@redhat.com, Valentine Sinitsyn This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8UcGProwGfSRknhIRcWb5gKNdqvmwCT8O From: Jan Kiszka To: David Kiarie , Eduardo Habkost Cc: QEMU Developers , Marcel Apfelbaum , "Michael S. Tsirkin" , Peter Xu , alex.williamson@redhat.com, Valentine Sinitsyn Message-ID: <57618CC1.9000505@web.de> Subject: Re: [V12 0/4] AMD IOMMU References: <1465993312-18119-1-git-send-email-davidkiarie4@gmail.com> <20160615142648.GG18662@thinpad.lan.raisama.net> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-06-15 19:07, David Kiarie wrote: > On Wed, Jun 15, 2016 at 5:26 PM, Eduardo Habkost = wrote: >> On Wed, Jun 15, 2016 at 03:21:48PM +0300, David Kiarie wrote: >>> Hi all, >>> >>> This patchset adds basic AMD IOMMU emulation support to Qemu. >>> >>> Changes since V11 >>> -AMD IOMMU is not started with -device amd-iommu (with a dependenc= y on Marcel's patches). >>> -IOMMU commands are represented using bitfields which is less erro= r prone and more readable[Peter] >>> -Changed from debug fprintfs to tracing[Jan] >> >> What were the issues that required the sysbus+PCI code you sent >> previously? How did you address them in this series? >=20 > Short answer: Those issues are not present in this patch. >=20 > Long answer: The sysbus + PCI code is necessary for interrupt > remapping to be implemented(it could also be done without sysbus + PCI > code but that wouldn't be in line with the Intel IOMMU interrupt > remapping code, which is already on the list). The idea is that X86 > IOMMUs should have a base class that implements common code. It was > decided that this class should be a SysBusDev(which works perfectly > with Intel IOMMU) but not with AMD IOMMU which has PCI properties. I > had to find a way to provide for the PCI properties once I inherit > from Intel IOMMU. >=20 > In this patchset, I have not inherited from the base class(it's not > merged yet) and even if it was merged I'd prefer to only use the > SysBus + PCI code when necessary(when I work on interrupt remapping) > so as to avoid delaying this patchset further. We specifically came to the conclusion that it is better to evolve the commodities between both IOMMU implementations (will be mostly about interrupt remapping) in-tree rather than in separate patch sets outside the mainline. Jan --8UcGProwGfSRknhIRcWb5gKNdqvmwCT8O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAldhjMEACgkQitSsb3rl5xRmVwCgkuvgDTm2bR6XD6Cr39xwRjEj 4VcAnj+xMbZaqt+VxIQ+5wq5bTY2I23P =M0jb -----END PGP SIGNATURE----- --8UcGProwGfSRknhIRcWb5gKNdqvmwCT8O--