From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Rithvik Patibandla <rithvikp98@gmail.com>, forest@alittletooquiet.net
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
habdul@visteon.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:vt6656:card.c:Fix comment block issue
Date: Wed, 15 Jun 2016 21:27:04 +0100 [thread overview]
Message-ID: <5761BA18.9070500@osg.samsung.com> (raw)
In-Reply-To: <20160611200858.GA21973@rithvik-IdeaPad>
On 11/06/16 21:08, Rithvik Patibandla wrote:
> Fix "Block comments use * on subsequent lines" and "Block comments use
> */ on trailing lines" warnings thrown by checkpatch.pl
>
> Signed-off-by: Rithvik Patibandla <rithvikp98@gmail.com>
> ---
> drivers/staging/vt6656/card.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index a382fc6..607834c 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -47,7 +47,8 @@
> #include "usbpipe.h"
>
> /* const u16 cwRXBCNTSFOff[MAX_RATE] =
> - {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */
> + * {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3};
> + */
>
> static const u16 cwRXBCNTSFOff[MAX_RATE] = {
> 192, 96, 34, 17, 34, 23, 17, 11, 8, 5, 4, 3
>
Hi Rithvik,
The following warning is indeed fixed :) This patch looks good.
WARNING: Block comments use * on subsequent lines
#50: FILE: drivers/staging/vt6656/card.c:50:
+/* const u16 cwRXBCNTSFOff[MAX_RATE] =
+ {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */
There are 32 other checks that checkpatch complains about in that file.
Please send fixes for those as well.
Luis
prev parent reply other threads:[~2016-06-15 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 20:08 [PATCH] staging:vt6656:card.c:Fix comment block issue Rithvik Patibandla
2016-06-15 20:27 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5761BA18.9070500@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=habdul@visteon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rithvikp98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.