From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v12 0/3] mempool: add external mempool manager
Date: Thu, 16 Jun 2016 08:47:46 +0100
Message-ID: <576259A2.4090200@intel.com>
References: <1465919341-3209-1-git-send-email-david.hunt@intel.com>
 <1465976824-83823-1-git-send-email-david.hunt@intel.com>
 <20160615121358.5ef9f142@pcviktorin.fit.vutbr.cz>
 <57614043.9090603@intel.com> <57614402.6020708@6wind.com>
 <576183AD.8070200@intel.com> <576184F7.3040206@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com
To: Olivier MATZ <olivier.matz@6wind.com>,
 Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 84746C3C2
 for <dev@dpdk.org>; Thu, 16 Jun 2016 09:47:49 +0200 (CEST)
In-Reply-To: <576184F7.3040206@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 15/6/2016 5:40 PM, Olivier MATZ wrote:
>
>
> On 06/15/2016 06:34 PM, Hunt, David wrote:
>>
>>
>> On 15/6/2016 1:03 PM, Olivier MATZ wrote:
>>> [...]
>>>
>>> The opaque pointer would be saved in mempool structure, and used
>>> when the mempool is populated (calling mempool_ops_alloc).
>>> The type of the structure pointed by the opaque has to be defined
>>> (and documented) into each mempool_ops manager.
>>>
>>>
>>> Olivier
>>
>>
>> OK, just to be sure before I post another patchset.....
>>
>> For the rte_mempool_struct:
>>          struct rte_mempool_memhdr_list mem_list; /**< List of memory
>> chunks */
>> +       void *ops_args;                  /**< optional args for ops
>> alloc. */
>>
>> (at the end of the struct, as it's just on the control path, not to
>> affect fast path)
>
> Hmm, I would put it just after pool_data.
>

When I move it to just after pool data, the performance of the 
mempool_perf_autotest drops by 2% on my machine for the local cache tests.
I think I should leave it where I suggested.

Regards,
David.