From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 1/6] drm/tilcdc: Restore old dpms state in pm_resume() Date: Thu, 16 Jun 2016 12:13:19 +0300 Message-ID: <57626DAF.5070307@ti.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1214036427==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1508B6E256 for ; Thu, 16 Jun 2016 09:13:28 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: bcousson@baylibre.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============1214036427== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J4CPsrFFAwMALcdTdEn181cMhqTB4OcE1" --J4CPsrFFAwMALcdTdEn181cMhqTB4OcE1 Content-Type: multipart/mixed; boundary="dr61utBlH8lLmVV4kgP6mLP4utL0WPsf4" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com, robdclark@gmail.com, bcousson@baylibre.com Message-ID: <57626DAF.5070307@ti.com> Subject: Re: [PATCH v2 1/6] drm/tilcdc: Restore old dpms state in pm_resume() References: In-Reply-To: --dr61utBlH8lLmVV4kgP6mLP4utL0WPsf4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15/06/16 11:39, Jyri Sarha wrote: > Restore old dpms state in pm_resume(). The dpms is turned off in > pm_suspend() and it should be restored to its original state in > pm_resume(). >=20 > Fixes commit 614b3cfeb8d2 ("drm/tilcdc: disable the lcd controller/dma > engine when suspend invoked") This still doesn't explain the issue (at least clearly). If you send a fix for some problem, it's good to have a clear explanation of what's the problem (from user's perspective, what does he see). Tomi --dr61utBlH8lLmVV4kgP6mLP4utL0WPsf4-- --J4CPsrFFAwMALcdTdEn181cMhqTB4OcE1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXYm2vAAoJEPo9qoy8lh71VvkQAKOcBTigZ9otaUGeJiylycDU ssZxIcZXFIbNvU13gV7PzcGsboQ3biQT7G3MUsiAiYSG04Cpucuot17PPPSv9NPn X3Vw5iObIDhFtRK0UEsTGwVFpU8slBDE2VixdxuRn6KR0yjZmZSf3ZeQDZtW2gRd vbh5BSf6DkINhpLTmGWojCnx833PpxnsBNjpj8h4GIODUVGH7QawBTtEU5isaM/Q ep983iJS8Bber9DIFJqoZYrHYx8IcuNdgwhQXsZzVAaT5766G9H49EAfpE7vdHcf s8vD7uEHgDYuiCznV3lcNCSW3zhySc1jjVnIt1WQ3yQeVldJpM5uuspfrBSUtrAK HwgodICD3DwM6QodpNW7h9A+CgZIWH7ZaCdKgPWYsgaPBY6v/yjajvNGQtLPhT1E 1GkXaac8LWFqjwjf0yiZ8EjSMWOxJOQAma01a+2p3AAFUjob2C0IEnU/UN4R9Vyt 1wbnmKv2qsk3Swsal8qAsdvlMfd+u7hy6e2p/GzdSVWqt4djSNbDAio10a3KtCHn MzoABMSGQFrWgijVy0Y0umzxXlxD7tq1h9i5E81NguA451cPs1KCLIOXmTgJoVY9 bj6598IkXxQSHRPQqgG0iVZ4/YMhJ1ghgB1p97u0s90wzL73RJDMc33YFesAsXZW 9ii3gn6t9TtO6dDQ0D/W =Xy+e -----END PGP SIGNATURE----- --J4CPsrFFAwMALcdTdEn181cMhqTB4OcE1-- --===============1214036427== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1214036427==--