From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 0/6] drm/tilcdc Fixes and cleanups Date: Thu, 16 Jun 2016 12:30:06 +0300 Message-ID: <5762719E.4080803@ti.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0867293798==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5277D6E9E7 for ; Thu, 16 Jun 2016 09:30:14 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: bcousson@baylibre.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============0867293798== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uLKi8jt1O1TGlVTEJ3xRrITw2UQjwckv2" --uLKi8jt1O1TGlVTEJ3xRrITw2UQjwckv2 Content-Type: multipart/mixed; boundary="x57omUn6HpoHWQs9g5g4e4iOGp6TaRDhc" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com, robdclark@gmail.com, bcousson@baylibre.com Message-ID: <5762719E.4080803@ti.com> Subject: Re: [PATCH v2 0/6] drm/tilcdc Fixes and cleanups References: In-Reply-To: --x57omUn6HpoHWQs9g5g4e4iOGp6TaRDhc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15/06/16 11:39, Jyri Sarha wrote: > Some fixes and cleanups that should get merged to tilcdc even if my > atomic changes are still a work in progress. >=20 > Jyri Sarha (6): > drm/tilcdc: Restore old dpms state in pm_resume() > drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ > function > drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into stop() > drm/tilcdc: Call drm_crtc_vblank_on() and *_off() in start() and > stop() > drm/tilcdc: Refer to panel.txt and tfp410.txt bindings in tilcdc.txt > drm/tilcdc: Avoid error print by of_graph_get_next_endpoint() >=20 > .../devicetree/bindings/display/tilcdc/tilcdc.txt | 4 ++ > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 66 ++++++++++++++= -------- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 + > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 + > drivers/gpu/drm/tilcdc/tilcdc_external.c | 13 ++++- > 5 files changed, 62 insertions(+), 26 deletions(-) >=20 Beside the minor comments I had, looks fine to me. Reviewed-by: Tomi Valkeinen Tomi --x57omUn6HpoHWQs9g5g4e4iOGp6TaRDhc-- --uLKi8jt1O1TGlVTEJ3xRrITw2UQjwckv2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXYnGeAAoJEPo9qoy8lh711IEP/1kpvdQ9qmHUSBklKMfLmq2F LBtXX/kFWShJfR6LXFwjNa2guSz0mjv4g8ProwNmWZDLRhWtr4Z100Vj2A9jgPgy 6VVE+M/6J96eOkNHWkBsAZQ6mPv79hMwY0cWjkOEgP3CMHnUVlPaU/h9PtCnCJlL uKR1Acgfi9DyEyRe+Frlzb94RLznts+BiPq28hq/QnxtlzPqQyAU0s1tgeKX+AgH sWkEC5NBhYcVXxktqWO3rcuMZ8oiKnlS9Xy8/Vrg/Ni7YP0aw5OlWzWZMw/nX7RR J+RZ9aVDbaqUptm4uz5MdnLwPpz7oqC/HHO8eKXKp7q3CQdAsAU7fuoiwG+CH4Av nR6+abSPQNTOGmhrwVhKvrUKeJ6X4OUaJ34IlBmRfCzQ14NsRGdpKf4dW9in6sz8 vSOzUOPPi0HPO9b16YAWeZH0Ct38AEURzbe6xyaYRXD9mpjJDQzFvheLwzYqSPIn /1e40Fy2Odg24/iTx/a82hj9HdJKKINkAUaEouKC7ZHMAT24+KeeY7nQA98gHYb/ /RRXzbMUJZxQOx9A6sMnb/VNJNyA4G1HzvUy3rU8fiHGOCHeEIhhVWhj5bi2wGjn 374ivQGlt+7q2zWAlF5yhONSGRqSDP6G2ExAxP96I3ekXu7a1TsNGaHLljmfwevK YuP55FK9AG8oLcr/s2eb =V+14 -----END PGP SIGNATURE----- --uLKi8jt1O1TGlVTEJ3xRrITw2UQjwckv2-- --===============0867293798== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0867293798==--