From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDV5y-0001zF-OH for qemu-devel@nongnu.org; Thu, 16 Jun 2016 07:04:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDV5u-0001JM-W9 for qemu-devel@nongnu.org; Thu, 16 Jun 2016 07:04:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:51013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDV5u-0001J1-O4 for qemu-devel@nongnu.org; Thu, 16 Jun 2016 07:04:18 -0400 References: <1466071320-10964-1-git-send-email-jgross@suse.com> <5762A17B02000078000F59F3@suse.com> From: Juergen Gross Message-ID: <576287AE.4060401@suse.com> Date: Thu, 16 Jun 2016 13:04:14 +0200 MIME-Version: 1.0 In-Reply-To: <5762A17B02000078000F59F3@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Beulich Cc: anthony.perard@citrix.com, sstabellini@kernel.org, xen-devel , qemu-devel@nongnu.org, kraxel@redhat.com On 16/06/16 12:54, Jan Beulich wrote: >>>> On 16.06.16 at 12:02, wrote: >> In case the word size of the domU and qemu running the qdisk backend >> differ BLKIF_OP_DISCARD will not work reliably, as the request >> structure in the ring have different layouts for different word size. >> >> Correct this by copying the request structure in case of different >> word size element by element in the BLKIF_OP_DISCARD case, too. >> >> Signed-off-by: Juergen Gross > > With the indentation (tabs vs blanks) fixed Hmm, qemu coding style is to use blanks. I could: a) leave the patch as is (changed lines indented with blanks) b) use tabs to indent (style of the modified file up to now) c) change the style of the file in this patch d) change the style of the file in a separate patch Any preferences? > Reviewed-by: Jan Beulich > > And maybe ... > >> @@ -82,7 +98,7 @@ static inline void blkif_get_x86_32_req(blkif_request_t *dst, blkif_x86_32_reque >> /* Prevent the compiler from using src->... instead. */ >> barrier(); >> if (dst->operation == BLKIF_OP_DISCARD) { >> - struct blkif_request_discard *s = (void *)src; >> + struct blkif_x86_32_request_discard *s = (void *)src; > > ... it would also be worth adding const here and ... > >> @@ -105,7 +121,7 @@ static inline void blkif_get_x86_64_req(blkif_request_t *dst, blkif_x86_64_reque >> /* Prevent the compiler from using src->... instead. */ >> barrier(); >> if (dst->operation == BLKIF_OP_DISCARD) { >> - struct blkif_request_discard *s = (void *)src; >> + struct blkif_x86_64_request_discard *s = (void *)src; > > ... here. Okay. Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix Date: Thu, 16 Jun 2016 13:04:14 +0200 Message-ID: <576287AE.4060401@suse.com> References: <1466071320-10964-1-git-send-email-jgross@suse.com> <5762A17B02000078000F59F3@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDV5y-0006XB-Ub for xen-devel@lists.xenproject.org; Thu, 16 Jun 2016 11:04:23 +0000 In-Reply-To: <5762A17B02000078000F59F3@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: anthony.perard@citrix.com, xen-devel , sstabellini@kernel.org, qemu-devel@nongnu.org, kraxel@redhat.com List-Id: xen-devel@lists.xenproject.org T24gMTYvMDYvMTYgMTI6NTQsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDE2LjA2LjE2IGF0 IDEyOjAyLCA8Skdyb3NzQHN1c2UuY29tPiB3cm90ZToKPj4gSW4gY2FzZSB0aGUgd29yZCBzaXpl IG9mIHRoZSBkb21VIGFuZCBxZW11IHJ1bm5pbmcgdGhlIHFkaXNrIGJhY2tlbmQKPj4gZGlmZmVy IEJMS0lGX09QX0RJU0NBUkQgd2lsbCBub3Qgd29yayByZWxpYWJseSwgYXMgdGhlIHJlcXVlc3QK Pj4gc3RydWN0dXJlIGluIHRoZSByaW5nIGhhdmUgZGlmZmVyZW50IGxheW91dHMgZm9yIGRpZmZl cmVudCB3b3JkIHNpemUuCj4+Cj4+IENvcnJlY3QgdGhpcyBieSBjb3B5aW5nIHRoZSByZXF1ZXN0 IHN0cnVjdHVyZSBpbiBjYXNlIG9mIGRpZmZlcmVudAo+PiB3b3JkIHNpemUgZWxlbWVudCBieSBl bGVtZW50IGluIHRoZSBCTEtJRl9PUF9ESVNDQVJEIGNhc2UsIHRvby4KPj4KPj4gU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgo+IAo+IFdpdGggdGhlIGluZGVu dGF0aW9uICh0YWJzIHZzIGJsYW5rcykgZml4ZWQKCkhtbSwgcWVtdSBjb2Rpbmcgc3R5bGUgaXMg dG8gdXNlIGJsYW5rcy4gSSBjb3VsZDoKYSkgbGVhdmUgdGhlIHBhdGNoIGFzIGlzIChjaGFuZ2Vk IGxpbmVzIGluZGVudGVkIHdpdGggYmxhbmtzKQpiKSB1c2UgdGFicyB0byBpbmRlbnQgKHN0eWxl IG9mIHRoZSBtb2RpZmllZCBmaWxlIHVwIHRvIG5vdykKYykgY2hhbmdlIHRoZSBzdHlsZSBvZiB0 aGUgZmlsZSBpbiB0aGlzIHBhdGNoCmQpIGNoYW5nZSB0aGUgc3R5bGUgb2YgdGhlIGZpbGUgaW4g YSBzZXBhcmF0ZSBwYXRjaAoKQW55IHByZWZlcmVuY2VzPwoKPiBSZXZpZXdlZC1ieTogSmFuIEJl dWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IAo+IEFuZCBtYXliZSAuLi4KPiAKPj4gQEAgLTgy LDcgKzk4LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGJsa2lmX2dldF94ODZfMzJfcmVxKGJsa2lm X3JlcXVlc3RfdCAqZHN0LCBibGtpZl94ODZfMzJfcmVxdWUKPj4gIAkvKiBQcmV2ZW50IHRoZSBj b21waWxlciBmcm9tIHVzaW5nIHNyYy0+Li4uIGluc3RlYWQuICovCj4+ICAJYmFycmllcigpOwo+ PiAgCWlmIChkc3QtPm9wZXJhdGlvbiA9PSBCTEtJRl9PUF9ESVNDQVJEKSB7Cj4+IC0JCXN0cnVj dCBibGtpZl9yZXF1ZXN0X2Rpc2NhcmQgKnMgPSAodm9pZCAqKXNyYzsKPj4gKyAgICAgICAgICAg ICAgICBzdHJ1Y3QgYmxraWZfeDg2XzMyX3JlcXVlc3RfZGlzY2FyZCAqcyA9ICh2b2lkICopc3Jj Owo+IAo+IC4uLiBpdCB3b3VsZCBhbHNvIGJlIHdvcnRoIGFkZGluZyBjb25zdCBoZXJlIGFuZCAu Li4KPiAKPj4gQEAgLTEwNSw3ICsxMjEsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYmxraWZfZ2V0 X3g4Nl82NF9yZXEoYmxraWZfcmVxdWVzdF90ICpkc3QsIGJsa2lmX3g4Nl82NF9yZXF1ZQo+PiAg CS8qIFByZXZlbnQgdGhlIGNvbXBpbGVyIGZyb20gdXNpbmcgc3JjLT4uLi4gaW5zdGVhZC4gKi8K Pj4gIAliYXJyaWVyKCk7Cj4+ICAJaWYgKGRzdC0+b3BlcmF0aW9uID09IEJMS0lGX09QX0RJU0NB UkQpIHsKPj4gLQkJc3RydWN0IGJsa2lmX3JlcXVlc3RfZGlzY2FyZCAqcyA9ICh2b2lkICopc3Jj Owo+PiArICAgICAgICAgICAgICAgIHN0cnVjdCBibGtpZl94ODZfNjRfcmVxdWVzdF9kaXNjYXJk ICpzID0gKHZvaWQgKilzcmM7Cj4gCj4gLi4uIGhlcmUuCgpPa2F5LgoKCkp1ZXJnZW4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg==