From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Berger Subject: Re: [PATCH] tpm_vtpm_proxy: fix sparse warning Date: Thu, 16 Jun 2016 09:39:38 -0400 Message-ID: <5762AC1A.8050702@linux.vnet.ibm.com> References: <1466073474-4381-1-git-send-email-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1466073474-4381-1-git-send-email-jarkko.sakkinen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jarkko Sakkinen , Peter Huewe Cc: linux-security-module@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , "moderated list:TPM DEVICE DRIVER" , open list List-Id: tpmdd-devel@lists.sourceforge.net On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote: > When running make C=2 M=drivers/char/tpm/ > > CC [M] drivers/char/tpm//tpm_crb.o > CHECK drivers/char/tpm//tpm_vtpm_proxy.c > drivers/char/tpm//tpm_vtpm_proxy.c:552:32: warning: incorrect type in assignment (different address spaces) > drivers/char/tpm//tpm_vtpm_proxy.c:552:32: expected struct vtpm_proxy_new_dev *vtpm_new_dev_p > drivers/char/tpm//tpm_vtpm_proxy.c:552:32: got void [noderef] *argp > drivers/char/tpm//tpm_vtpm_proxy.c:553:51: warning: incorrect type in argument 2 (different address spaces) > drivers/char/tpm//tpm_vtpm_proxy.c:553:51: expected void const [noderef] *from > drivers/char/tpm//tpm_vtpm_proxy.c:553:51: got struct vtpm_proxy_new_dev *vtpm_new_dev_p > drivers/char/tpm//tpm_vtpm_proxy.c:559:34: warning: incorrect type in argument 1 (different address spaces) > drivers/char/tpm//tpm_vtpm_proxy.c:559:34: expected void [noderef] *to > drivers/char/tpm//tpm_vtpm_proxy.c:559:34: got struct vtpm_proxy_new_dev *vtpm_new_dev_p > > The __user annotation was missing from the corresponding variable. > > Signed-off-by: Jarkko Sakkinen Tested-by: Stefan Berger PS: I get similar warnings for line 248 in tpm_crb.c.