All of lore.kernel.org
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm64: dts: juno: add arm, primecell-periphid override
Date: Thu, 16 Jun 2016 15:42:27 +0100	[thread overview]
Message-ID: <5762BAD3.6050405@arm.com> (raw)
In-Reply-To: <1465228765-14038-3-git-send-email-sudeep.holla@arm.com>



On 06/06/16 16:59, Sudeep Holla wrote:
> The Linux AMBA framework probes the peripheral ids when adding the amba
> devices very early on the boot. Generally they are on APB bus and just
> require APB clocks to be on even when most of the core logic of the IP
> is powered down.
>
> However on Juno, the entire debugsys domain needs to be ON to access
> those CID/PID registers and hence broken by design. Accessing those
> while debugsys power domain is off will lead to the bridge stalling the
> transactions instead of returning the slave error.
>
> Since keeping the power domain on by default affects the core power(by
> preventing cores entering deeper idle states), it's not feasible
> solution. Instead we can provide arm,primecell-periphid override in the
> device tree that prevents accessing the device early in the boot.
>

OK, I recently found out that AMBA bus/infrastructure can deal with 
powered off domains even while adding the devices. That makes this patch 
redundant. I had missed it initially as I tested with !CONFIG_PM
option.

So I raised the issue with !CONFIG_PM option[1] and it was suggested to 
make platform select the same[2] as there's no simple way to deal with
that.

Hence I will drop this patch but will post patch to select PM from
ARCH_VEXPRESS to ensure we always have it enabled to deal with this
platform issue.

-- 
Regards,
Sudeep


[1] http://marc.info/?l=linux-pm&m=146607608629880&w=2
[2] http://marc.info/?l=linux-pm&m=146608125731479&w=2

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
	Jon Medhurst <tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Mathieu Poirier
	<mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Suzuki K Poulose <suzuki.poulose-5wv7dgnIgG8@public.gmane.org>,
	Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>,
	Lorenzo Pieralisi
	<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] arm64: dts: juno: add arm,primecell-periphid override
Date: Thu, 16 Jun 2016 15:42:27 +0100	[thread overview]
Message-ID: <5762BAD3.6050405@arm.com> (raw)
In-Reply-To: <1465228765-14038-3-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>



On 06/06/16 16:59, Sudeep Holla wrote:
> The Linux AMBA framework probes the peripheral ids when adding the amba
> devices very early on the boot. Generally they are on APB bus and just
> require APB clocks to be on even when most of the core logic of the IP
> is powered down.
>
> However on Juno, the entire debugsys domain needs to be ON to access
> those CID/PID registers and hence broken by design. Accessing those
> while debugsys power domain is off will lead to the bridge stalling the
> transactions instead of returning the slave error.
>
> Since keeping the power domain on by default affects the core power(by
> preventing cores entering deeper idle states), it's not feasible
> solution. Instead we can provide arm,primecell-periphid override in the
> device tree that prevents accessing the device early in the boot.
>

OK, I recently found out that AMBA bus/infrastructure can deal with 
powered off domains even while adding the devices. That makes this patch 
redundant. I had missed it initially as I tested with !CONFIG_PM
option.

So I raised the issue with !CONFIG_PM option[1] and it was suggested to 
make platform select the same[2] as there's no simple way to deal with
that.

Hence I will drop this patch but will post patch to select PM from
ARCH_VEXPRESS to ensure we always have it enabled to deal with this
platform issue.

-- 
Regards,
Sudeep


[1] http://marc.info/?l=linux-pm&m=146607608629880&w=2
[2] http://marc.info/?l=linux-pm&m=146608125731479&w=2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-06-16 14:42 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 15:59 [PATCH 0/3] arm64: dts: juno: add coresight support Sudeep Holla
2016-06-06 15:59 ` [PATCH 1/3] " Sudeep Holla
2016-06-06 15:59   ` Sudeep Holla
2016-06-08 16:04   ` Liviu Dudau
2016-06-08 16:04     ` Liviu Dudau
2016-06-12 21:57   ` Mathieu Poirier
2016-06-12 21:57     ` Mathieu Poirier
2016-06-13  3:05     ` Mathieu Poirier
2016-06-13  3:05       ` Mathieu Poirier
2016-06-13  9:18     ` Sudeep Holla
2016-06-13  9:18       ` Sudeep Holla
2016-06-13 14:47       ` Mathieu Poirier
2016-06-13 14:47         ` Mathieu Poirier
2016-06-13 14:53         ` Sudeep Holla
2016-06-13 14:53           ` Sudeep Holla
2016-06-17 15:29   ` Mathieu Poirier
2016-06-17 15:29     ` Mathieu Poirier
2016-06-17 15:33     ` Sudeep Holla
2016-06-17 15:33       ` Sudeep Holla
2016-06-21  5:41   ` Olof Johansson
2016-06-21  5:41     ` Olof Johansson
2016-06-21  8:44     ` Suzuki K Poulose
2016-06-21  8:44       ` Suzuki K Poulose
2016-06-21 11:27     ` Sudeep Holla
2016-06-21 11:27       ` Sudeep Holla
2016-06-21 16:30       ` Mathieu Poirier
2016-06-21 16:30         ` Mathieu Poirier
2016-06-28 17:03       ` Sudeep Holla
2016-06-28 17:03         ` Sudeep Holla
2016-06-06 15:59 ` [PATCH 2/3] arm64: dts: juno: add arm,primecell-periphid override Sudeep Holla
2016-06-06 15:59   ` Sudeep Holla
2016-06-08 16:05   ` [PATCH 2/3] arm64: dts: juno: add arm, primecell-periphid override Liviu Dudau
2016-06-08 16:05     ` [PATCH 2/3] arm64: dts: juno: add arm,primecell-periphid override Liviu Dudau
2016-06-16 14:42   ` Sudeep Holla [this message]
2016-06-16 14:42     ` Sudeep Holla
2016-06-06 15:59 ` [PATCH 3/3] arm64: dts: juno: add SCPI power domains for device power management Sudeep Holla
2016-06-06 15:59   ` Sudeep Holla
2016-06-08 16:05   ` Liviu Dudau
2016-06-08 16:05     ` Liviu Dudau
2016-06-17 15:30   ` Mathieu Poirier
2016-06-17 15:30     ` Mathieu Poirier
2016-07-06 10:15 ` [PATCH v2 0/2] arm64: dts: juno: add coresight support Sudeep Holla
2016-07-06 10:15   ` Sudeep Holla
2016-07-06 10:15   ` [PATCH v2 1/2] " Sudeep Holla
2016-07-06 10:15     ` Sudeep Holla
2016-07-06 10:15   ` [PATCH v2 2/2] arm64: dts: juno: add SCPI power domains for device power management Sudeep Holla
2016-07-06 10:15     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5762BAD3.6050405@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.