All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Mathieu Malaterre <mathieu.malaterre@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] of: fix memory leak related to safe_name()
Date: Thu, 16 Jun 2016 10:47:21 -0700	[thread overview]
Message-ID: <5762E629.8060301@gmail.com> (raw)
In-Reply-To: <CA+7wUsz0OnOHVyGTE=nzAbCi_GbmLvU-Q4wQHjs=SOLRUB4E5w@mail.gmail.com>

On 06/16/16 00:51, Mathieu Malaterre wrote:
> Sorry, symptoms not solved. According to kmemleak, I have now:
> 
> [  661.323100] kmemleak: 100 new suspected memory leaks (see
> /sys/kernel/debug/kmemleak)
> [ 1260.226120] kmemleak: 1 new suspected memory leaks (see
> /sys/kernel/debug/kmemleak)
> 
> # head -40 /sys/kernel/debug/kmemleak
> unreferenced object 0xdf5326a0 (size 32):
>   comm "swapper", pid 1, jiffies 4294892300 (age 2564.708s)
>   hex dump (first 32 bytes):
>     62 61 73 65 00 00 4c d8 c5 78 df dc cc 43 e4 bc  base..L..x...C..
>     c4 c8 ec 8c ee de ce cf e8 c9 8a ea dc cc c6 fd  ................
>   backtrace:
>     [<c014d4d8>] kstrdup+0x48/0x88
>     [<c0454678>] __of_attach_node_sysfs+0xf0/0x100
>     [<c075f21c>] of_core_init+0x8c/0xf8
>     [<c0729594>] kernel_init_freeable+0xd4/0x208
>     [<c00047e8>] kernel_init+0x24/0x11c
>     [<c00158ec>] ret_from_kernel_thread+0x5c/0x64

< snip >

Brown paper bag time.  I left out the kfree() in the one place that
your first patch added it.  Version 3 on the way.

-Frank

      reply	other threads:[~2016-06-16 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 20:42 [PATCH v2] of: fix memory leak related to safe_name() Frank Rowand
2016-06-16  7:15 ` Mathieu Malaterre
2016-06-16  7:51   ` Mathieu Malaterre
2016-06-16 17:47     ` Frank Rowand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5762E629.8060301@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mathieu.malaterre@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.