From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexander Shiyan <shc_work@mail.ru>, alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: codecs: Remove "select REGMAP_SPI/REGMAP_I2C"
Date: Thu, 16 Jun 2016 21:31:18 +0200 [thread overview]
Message-ID: <5762FE86.4090005@metafoo.de> (raw)
In-Reply-To: <1466103612-8424-1-git-send-email-shc_work@mail.ru>
On 06/16/2016 09:00 PM, Alexander Shiyan wrote:
> REGMAP_SPI and REGMAP_I2C is selected automatically by SND_SOC,
> so no additional actions is required.
To be honest I'd rather have this the other way around. Remove them from
SND_SOC and let every CODEC select them individually. That would be the
technically correct approach.
Otherwise if we want argue that a system using ASoC has probably at least
one CODEC device that either regmap SPI or regmap I2C and that's why it
makes sense for them to be selected automatically, we can also argue that
these days any system that has SPI or I2C support has likely one device that
either uses regmap SPI or regmap I2C, so they should always be enabled.
next prev parent reply other threads:[~2016-06-16 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 19:00 [PATCH] ASoC: codecs: Remove "select REGMAP_SPI/REGMAP_I2C" Alexander Shiyan
2016-06-16 19:31 ` Lars-Peter Clausen [this message]
2016-06-17 10:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762FE86.4090005@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=shc_work@mail.ru \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.