From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDrCM-0007nO-KD for qemu-devel@nongnu.org; Fri, 17 Jun 2016 06:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDrCI-0005MR-Iw for qemu-devel@nongnu.org; Fri, 17 Jun 2016 06:40:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:54104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDrCI-0005MN-6x for qemu-devel@nongnu.org; Fri, 17 Jun 2016 06:40:22 -0400 References: <1466154874-6218-1-git-send-email-jgross@suse.com> <5763DE5D02000078000F5FF8@prv-mh.provo.novell.com> <5763C6CA.4090705@suse.com> <5763CC05.3030008@suse.com> From: Juergen Gross Message-ID: <5763D394.8000102@suse.com> Date: Fri, 17 Jun 2016 12:40:20 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant , Jan Beulich Cc: Anthony Perard , xen-devel , "sstabellini@kernel.org" , "qemu-devel@nongnu.org" , "kraxel@redhat.com" On 17/06/16 12:15, Paul Durrant wrote: >> -----Original Message----- >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of >> Juergen Gross >> Sent: 17 June 2016 11:08 >> To: Paul Durrant; Jan Beulich >> Cc: Anthony Perard; xen-devel; sstabellini@kernel.org; qemu- >> devel@nongnu.org; kraxel@redhat.com >> Subject: Re: [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for >> 32/64 word size mix >> >> On 17/06/16 11:50, Paul Durrant wrote: >>>> -----Original Message----- >>>> From: Juergen Gross [mailto:jgross@suse.com] >>>> Sent: 17 June 2016 10:46 >>>> To: Paul Durrant; Jan Beulich >>>> Cc: Anthony Perard; xen-devel; sstabellini@kernel.org; qemu- >>>> devel@nongnu.org; kraxel@redhat.com >>>> Subject: Re: [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for >>>> 32/64 word size mix >>>> >>>> On 17/06/16 11:37, Paul Durrant wrote: >>>>>> -----Original Message----- >>>>>> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf >> Of >>>> Jan >>>>>> Beulich >>>>>> Sent: 17 June 2016 10:26 >>>>>> To: Juergen Gross >>>>>> Cc: Anthony Perard; xen-devel; sstabellini@kernel.org; qemu- >>>>>> devel@nongnu.org; kraxel@redhat.com >>>>>> Subject: Re: [Xen-devel] [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD >> for >>>>>> 32/64 word size mix >>>>>> >>>>>>>>> On 17.06.16 at 11:14, wrote: >>>>>>> In case the word size of the domU and qemu running the qdisk >> backend >>>>>>> differ BLKIF_OP_DISCARD will not work reliably, as the request >>>>>>> structure in the ring have different layouts for different word size. >>>>>>> >>>>>>> Correct this by copying the request structure in case of different >>>>>>> word size element by element in the BLKIF_OP_DISCARD case, too. >>>>>>> >>>>>>> The easiest way to achieve this is to resync hw/block/xen_blkif.h with >>>>>>> its original source from the Linux kernel. >>>>>>> >>>>>>> Signed-off-by: Juergen Gross >>>>>>> --- >>>>>>> V2: resync with Linux kernel version of hw/block/xen_blkif.h as >>>>>>> suggested by Paul Durrant >>>>>> >>>>>> Oh, I didn't realize he suggested syncing with the Linux variant. >>>>>> Why not with the canonical one? I have to admit that I particularly >>>>>> dislike Linux'es strange union-izng, mainly because of it requiring >>>>>> this myriad of __attribute__((__packed__)). >>>>>> >>>>> >>>>> Yes, it's truly grotesque and such things should be blown away with >>>> extreme prejudice. >>>> >>>> Sorry, I'm confused now. >>>> >>>> Do you still mandate for the resync or not? >>>> >>>> Resyncing with elimination of all the __packed__ stuff seems not to be >>>> a proper alternative as this would require a major rework. >>> >>> Why? Replacing the existing horribleness with the canonical header (fixed >> for style) might mean a large diff but it should be functionally the same or >> something has gone very seriously wrong. If the extra part you need is not in >> the canonical header then adding this as a second patch seems like a >> reasonable plan. >> >> I think you don't realize that qemu is built using the public headers >> from the Xen build environment. So there is no way to resync with the >> canonical header as this isn't part of the qemu tree. >> > > Now I'm confused... you're posting a patch to hw/block/xen_blkif.h. That's in the QEMU source, right? That's not a Xen public header but is a Linux mangled variant of a Xen public header. So, actually, I guess the question is why can't this header just go away and QEMU use the canonical header directly from Xen? No, hw/block/xen_blkif.h is based on the Linux header drivers/block/xen-blkback/common.h which is an add-on header to the canonical-based Linux header include/xen/interface/io/blkif.h >> The header in question is originating from the Linux one which is an >> add-on of the canonical header containing the explicit 32- and 64-bit >> variants of the xenbus protocol and the conversion routines between >> those. >> >> It would be possible to add these parts to the canonical header, but >> do we really want that? >> > > No, we shouldn't be taking Linux brokenness into the canonical header. Okay, so then back to the first approach using hw/block/xen_blkif.h as today and adapting the style first and then doing the necessary code correction? Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v2] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix Date: Fri, 17 Jun 2016 12:40:20 +0200 Message-ID: <5763D394.8000102@suse.com> References: <1466154874-6218-1-git-send-email-jgross@suse.com> <5763DE5D02000078000F5FF8@prv-mh.provo.novell.com> <5763C6CA.4090705@suse.com> <5763CC05.3030008@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDrCJ-0008UA-Ng for xen-devel@lists.xenproject.org; Fri, 17 Jun 2016 10:40:23 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Paul Durrant , Jan Beulich Cc: Anthony Perard , xen-devel , "sstabellini@kernel.org" , "qemu-devel@nongnu.org" , "kraxel@redhat.com" List-Id: xen-devel@lists.xenproject.org T24gMTcvMDYvMTYgMTI6MTUsIFBhdWwgRHVycmFudCB3cm90ZToKPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0KPj4gRnJvbTogWGVuLWRldmVsIFttYWlsdG86eGVuLWRldmVsLWJvdW5jZXNA bGlzdHMueGVuLm9yZ10gT24gQmVoYWxmIE9mCj4+IEp1ZXJnZW4gR3Jvc3MKPj4gU2VudDogMTcg SnVuZSAyMDE2IDExOjA4Cj4+IFRvOiBQYXVsIER1cnJhbnQ7IEphbiBCZXVsaWNoCj4+IENjOiBB bnRob255IFBlcmFyZDsgeGVuLWRldmVsOyBzc3RhYmVsbGluaUBrZXJuZWwub3JnOyBxZW11LQo+ PiBkZXZlbEBub25nbnUub3JnOyBrcmF4ZWxAcmVkaGF0LmNvbQo+PiBTdWJqZWN0OiBSZTogW1hl bi1kZXZlbF0gW1BBVENIIHYyXSB4ZW46IGZpeCBxZGlzayBCTEtJRl9PUF9ESVNDQVJEIGZvcgo+ PiAzMi82NCB3b3JkIHNpemUgbWl4Cj4+Cj4+IE9uIDE3LzA2LzE2IDExOjUwLCBQYXVsIER1cnJh bnQgd3JvdGU6Cj4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4+PiBGcm9tOiBKdWVy Z2VuIEdyb3NzIFttYWlsdG86amdyb3NzQHN1c2UuY29tXQo+Pj4+IFNlbnQ6IDE3IEp1bmUgMjAx NiAxMDo0Ngo+Pj4+IFRvOiBQYXVsIER1cnJhbnQ7IEphbiBCZXVsaWNoCj4+Pj4gQ2M6IEFudGhv bnkgUGVyYXJkOyB4ZW4tZGV2ZWw7IHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc7IHFlbXUtCj4+Pj4g ZGV2ZWxAbm9uZ251Lm9yZzsga3JheGVsQHJlZGhhdC5jb20KPj4+PiBTdWJqZWN0OiBSZTogW1hl bi1kZXZlbF0gW1BBVENIIHYyXSB4ZW46IGZpeCBxZGlzayBCTEtJRl9PUF9ESVNDQVJEIGZvcgo+ Pj4+IDMyLzY0IHdvcmQgc2l6ZSBtaXgKPj4+Pgo+Pj4+IE9uIDE3LzA2LzE2IDExOjM3LCBQYXVs IER1cnJhbnQgd3JvdGU6Cj4+Pj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+Pj4+Pj4g RnJvbTogWGVuLWRldmVsIFttYWlsdG86eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVuLm9yZ10g T24gQmVoYWxmCj4+IE9mCj4+Pj4gSmFuCj4+Pj4+PiBCZXVsaWNoCj4+Pj4+PiBTZW50OiAxNyBK dW5lIDIwMTYgMTA6MjYKPj4+Pj4+IFRvOiBKdWVyZ2VuIEdyb3NzCj4+Pj4+PiBDYzogQW50aG9u eSBQZXJhcmQ7IHhlbi1kZXZlbDsgc3N0YWJlbGxpbmlAa2VybmVsLm9yZzsgcWVtdS0KPj4+Pj4+ IGRldmVsQG5vbmdudS5vcmc7IGtyYXhlbEByZWRoYXQuY29tCj4+Pj4+PiBTdWJqZWN0OiBSZTog W1hlbi1kZXZlbF0gW1BBVENIIHYyXSB4ZW46IGZpeCBxZGlzayBCTEtJRl9PUF9ESVNDQVJECj4+ IGZvcgo+Pj4+Pj4gMzIvNjQgd29yZCBzaXplIG1peAo+Pj4+Pj4KPj4+Pj4+Pj4+IE9uIDE3LjA2 LjE2IGF0IDExOjE0LCA8Skdyb3NzQHN1c2UuY29tPiB3cm90ZToKPj4+Pj4+PiBJbiBjYXNlIHRo ZSB3b3JkIHNpemUgb2YgdGhlIGRvbVUgYW5kIHFlbXUgcnVubmluZyB0aGUgcWRpc2sKPj4gYmFj a2VuZAo+Pj4+Pj4+IGRpZmZlciBCTEtJRl9PUF9ESVNDQVJEIHdpbGwgbm90IHdvcmsgcmVsaWFi bHksIGFzIHRoZSByZXF1ZXN0Cj4+Pj4+Pj4gc3RydWN0dXJlIGluIHRoZSByaW5nIGhhdmUgZGlm ZmVyZW50IGxheW91dHMgZm9yIGRpZmZlcmVudCB3b3JkIHNpemUuCj4+Pj4+Pj4KPj4+Pj4+PiBD b3JyZWN0IHRoaXMgYnkgY29weWluZyB0aGUgcmVxdWVzdCBzdHJ1Y3R1cmUgaW4gY2FzZSBvZiBk aWZmZXJlbnQKPj4+Pj4+PiB3b3JkIHNpemUgZWxlbWVudCBieSBlbGVtZW50IGluIHRoZSBCTEtJ Rl9PUF9ESVNDQVJEIGNhc2UsIHRvby4KPj4+Pj4+Pgo+Pj4+Pj4+IFRoZSBlYXNpZXN0IHdheSB0 byBhY2hpZXZlIHRoaXMgaXMgdG8gcmVzeW5jIGh3L2Jsb2NrL3hlbl9ibGtpZi5oIHdpdGgKPj4+ Pj4+PiBpdHMgb3JpZ2luYWwgc291cmNlIGZyb20gdGhlIExpbnV4IGtlcm5lbC4KPj4+Pj4+Pgo+ Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KPj4+ Pj4+PiAtLS0KPj4+Pj4+PiBWMjogcmVzeW5jIHdpdGggTGludXgga2VybmVsIHZlcnNpb24gb2Yg aHcvYmxvY2sveGVuX2Jsa2lmLmggYXMKPj4+Pj4+PiAgICAgc3VnZ2VzdGVkIGJ5IFBhdWwgRHVy cmFudAo+Pj4+Pj4KPj4+Pj4+IE9oLCBJIGRpZG4ndCByZWFsaXplIGhlIHN1Z2dlc3RlZCBzeW5j aW5nIHdpdGggdGhlIExpbnV4IHZhcmlhbnQuCj4+Pj4+PiBXaHkgbm90IHdpdGggdGhlIGNhbm9u aWNhbCBvbmU/IEkgaGF2ZSB0byBhZG1pdCB0aGF0IEkgcGFydGljdWxhcmx5Cj4+Pj4+PiBkaXNs aWtlIExpbnV4J2VzIHN0cmFuZ2UgdW5pb24taXpuZywgbWFpbmx5IGJlY2F1c2Ugb2YgaXQgcmVx dWlyaW5nCj4+Pj4+PiB0aGlzIG15cmlhZCBvZiBfX2F0dHJpYnV0ZV9fKChfX3BhY2tlZF9fKSku Cj4+Pj4+Pgo+Pj4+Pgo+Pj4+PiBZZXMsIGl0J3MgdHJ1bHkgZ3JvdGVzcXVlIGFuZCBzdWNoIHRo aW5ncyBzaG91bGQgYmUgYmxvd24gYXdheSB3aXRoCj4+Pj4gZXh0cmVtZSBwcmVqdWRpY2UuCj4+ Pj4KPj4+PiBTb3JyeSwgSSdtIGNvbmZ1c2VkIG5vdy4KPj4+Pgo+Pj4+IERvIHlvdSBzdGlsbCBt YW5kYXRlIGZvciB0aGUgcmVzeW5jIG9yIG5vdD8KPj4+Pgo+Pj4+IFJlc3luY2luZyB3aXRoIGVs aW1pbmF0aW9uIG9mIGFsbCB0aGUgX19wYWNrZWRfXyBzdHVmZiBzZWVtcyBub3QgdG8gYmUKPj4+ PiBhIHByb3BlciBhbHRlcm5hdGl2ZSBhcyB0aGlzIHdvdWxkIHJlcXVpcmUgYSBtYWpvciByZXdv cmsuCj4+Pgo+Pj4gV2h5PyBSZXBsYWNpbmcgdGhlIGV4aXN0aW5nIGhvcnJpYmxlbmVzcyB3aXRo IHRoZSBjYW5vbmljYWwgaGVhZGVyIChmaXhlZAo+PiBmb3Igc3R5bGUpIG1pZ2h0IG1lYW4gYSBs YXJnZSBkaWZmIGJ1dCBpdCBzaG91bGQgYmUgZnVuY3Rpb25hbGx5IHRoZSBzYW1lIG9yCj4+IHNv bWV0aGluZyBoYXMgZ29uZSB2ZXJ5IHNlcmlvdXNseSB3cm9uZy4gSWYgdGhlIGV4dHJhIHBhcnQg eW91IG5lZWQgaXMgbm90IGluCj4+IHRoZSBjYW5vbmljYWwgaGVhZGVyIHRoZW4gYWRkaW5nIHRo aXMgYXMgYSBzZWNvbmQgcGF0Y2ggc2VlbXMgbGlrZSBhCj4+IHJlYXNvbmFibGUgcGxhbi4KPj4K Pj4gSSB0aGluayB5b3UgZG9uJ3QgcmVhbGl6ZSB0aGF0IHFlbXUgaXMgYnVpbHQgdXNpbmcgdGhl IHB1YmxpYyBoZWFkZXJzCj4+IGZyb20gdGhlIFhlbiBidWlsZCBlbnZpcm9ubWVudC4gU28gdGhl cmUgaXMgbm8gd2F5IHRvIHJlc3luYyB3aXRoIHRoZQo+PiBjYW5vbmljYWwgaGVhZGVyIGFzIHRo aXMgaXNuJ3QgcGFydCBvZiB0aGUgcWVtdSB0cmVlLgo+Pgo+IAo+IE5vdyBJJ20gY29uZnVzZWQu Li4geW91J3JlIHBvc3RpbmcgYSBwYXRjaCB0byBody9ibG9jay94ZW5fYmxraWYuaC4gVGhhdCdz IGluIHRoZSBRRU1VIHNvdXJjZSwgcmlnaHQ/IFRoYXQncyBub3QgYSBYZW4gcHVibGljIGhlYWRl ciBidXQgaXMgYSBMaW51eCBtYW5nbGVkIHZhcmlhbnQgb2YgYSBYZW4gcHVibGljIGhlYWRlci4g U28sIGFjdHVhbGx5LCBJIGd1ZXNzIHRoZSBxdWVzdGlvbiBpcyB3aHkgY2FuJ3QgdGhpcyBoZWFk ZXIganVzdCBnbyBhd2F5IGFuZCBRRU1VIHVzZSB0aGUgY2Fub25pY2FsIGhlYWRlciBkaXJlY3Rs eSBmcm9tIFhlbj8KCk5vLCBody9ibG9jay94ZW5fYmxraWYuaCBpcyBiYXNlZCBvbiB0aGUgTGlu dXggaGVhZGVyCmRyaXZlcnMvYmxvY2sveGVuLWJsa2JhY2svY29tbW9uLmggd2hpY2ggaXMgYW4g YWRkLW9uIGhlYWRlciB0byB0aGUKY2Fub25pY2FsLWJhc2VkIExpbnV4IGhlYWRlciBpbmNsdWRl L3hlbi9pbnRlcmZhY2UvaW8vYmxraWYuaAoKPj4gVGhlIGhlYWRlciBpbiBxdWVzdGlvbiBpcyBv cmlnaW5hdGluZyBmcm9tIHRoZSBMaW51eCBvbmUgd2hpY2ggaXMgYW4KPj4gYWRkLW9uIG9mIHRo ZSBjYW5vbmljYWwgaGVhZGVyIGNvbnRhaW5pbmcgdGhlIGV4cGxpY2l0IDMyLSBhbmQgNjQtYml0 Cj4+IHZhcmlhbnRzIG9mIHRoZSB4ZW5idXMgcHJvdG9jb2wgYW5kIHRoZSBjb252ZXJzaW9uIHJv dXRpbmVzIGJldHdlZW4KPj4gdGhvc2UuCj4+Cj4+IEl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGFk ZCB0aGVzZSBwYXJ0cyB0byB0aGUgY2Fub25pY2FsIGhlYWRlciwgYnV0Cj4+IGRvIHdlIHJlYWxs eSB3YW50IHRoYXQ/Cj4+Cj4gCj4gTm8sIHdlIHNob3VsZG4ndCBiZSB0YWtpbmcgTGludXggYnJv a2VubmVzcyBpbnRvIHRoZSBjYW5vbmljYWwgaGVhZGVyLgoKT2theSwgc28gdGhlbiBiYWNrIHRv IHRoZSBmaXJzdCBhcHByb2FjaCB1c2luZyBody9ibG9jay94ZW5fYmxraWYuaCBhcwp0b2RheSBh bmQgYWRhcHRpbmcgdGhlIHN0eWxlIGZpcnN0IGFuZCB0aGVuIGRvaW5nIHRoZSBuZWNlc3Nhcnkg Y29kZQpjb3JyZWN0aW9uPwoKCkp1ZXJnZW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=