From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 99F2FE00D9A; Fri, 17 Jun 2016 04:16:50 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.51 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id EAFDCE00D8A for ; Fri, 17 Jun 2016 04:16:47 -0700 (PDT) Received: by mail-wm0-f51.google.com with SMTP id f126so84798479wma.1 for ; Fri, 17 Jun 2016 04:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=prN9oWHhUmS6P8WSIvM6HljrGEgQtkqQG6zKZxS2f5U=; b=1mSd2vZtEA5+td6lwfLyrCNTa+6q3TnzUkacYQ6ufy9nCEgNm7u8+j8gOeuX0WRwCF JM5e9HbY95RBxlO8cgJ9HTAs7ndoZfne9Y/Vt+5ui2yN+KsfepMOA0Sn/3jA95BIt+g8 g8uqCBV8jY8HEI4z0IzShPcOVNtu1CMOapy8XZVezmn8lH6lqW1RZf4aCMEZkQaHrVRr BOZ6AKq+qQP9Cmbn+9fL8LZJSUM14FsR41pHy3i21ELIxs1Mp2Q1pnYeNErSu+2ZC1og msUHHdNd+Uxe0C+1EVDUjY42F4z+cdJpp7ljtAMw4qzPhPCJLXR6I6PNZU4bUKBkGRtl 8nQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=prN9oWHhUmS6P8WSIvM6HljrGEgQtkqQG6zKZxS2f5U=; b=Jpps00GJY+vtxzTmUa1WG2CukXZdxPvx7yHImB6KfA3qhY2ZRY9ltoLOd+FGZPMzE7 HeL3hqHYcY+Fi9cwHr2zz5JChA2yxfdMW5oiszwjyc/xFz6nxC70Hok6OmcCRPBRHQKi sVmN7MnFs+IPJI+wBI81cjFNXRW/D+u2ec3aL++CZ4tc/rSpRLbtiNpX6yQePgIKeIQ1 TEcdkU0MBaJiRPdFMeE/RNsgdqH/eJ8YEbBpf+uRijNfLImSeFVAtjCce46xteLyPLwx Nq6nYWfr183O7vzoWqv6TiQT0G7pt5DpXDwguNpkcMFU26FPKGRMbm4aLaWFhLrNYkGA P0gw== X-Gm-Message-State: ALyK8tL6ZksT7nTO2KOUdmAEXvFzlFg/hAAxmUaRDkwwBxy+Dah1BqmL4ii3t3YNZEEUtnZA X-Received: by 10.194.106.132 with SMTP id gu4mr1751470wjb.25.1466162206150; Fri, 17 Jun 2016 04:16:46 -0700 (PDT) Received: from [192.168.0.78] (host86-169-85-169.range86-169.btcentralplus.com. [86.169.85.169]) by smtp.googlemail.com with ESMTPSA id qm9sm2533163wjc.36.2016.06.17.04.16.45 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 04:16:45 -0700 (PDT) To: toaster@yoctoproject.org References: <1466156485-11058-1-git-send-email-elliot.smith@intel.com> <1466156485-11058-2-git-send-email-elliot.smith@intel.com> From: Michael Wood Message-ID: <5763DC1C.2000006@intel.com> Date: Fri, 17 Jun 2016 12:16:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466156485-11058-2-git-send-email-elliot.smith@intel.com> Subject: Re: [PATCH 2/2] toaster-tests: define capabilities for latest Firefox driver X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 11:16:50 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 17/06/16 10:41, Elliot Smith wrote: > The Firefox 47 WebDriver requires a download of a separate binary > and an additional capability to be defined on the driver. > > Modify our tests so that when Firefox 47 is set as the browser > for the tests, this capability is defined. Also add a note to the > README about the additional installation steps required. > > Signed-off-by: Elliot Smith > --- > bitbake/lib/toaster/tests/browser/README | 9 ++++++++- > bitbake/lib/toaster/tests/browser/selenium_helpers.py | 5 ++++- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/bitbake/lib/toaster/tests/browser/README b/bitbake/lib/toaster/tests/browser/README > index f57154e..43e14c5 100644 > --- a/bitbake/lib/toaster/tests/browser/README > +++ b/bitbake/lib/toaster/tests/browser/README > @@ -24,7 +24,14 @@ To run tests against PhantomJS (headless): > * On *nix systems, put phantomjs on PATH > * Not tested on Windows > > -Firefox should work without requiring additional software to be installed. > +To run tests against Firefox: > + > +* Firefox versions 46 or earlier should work without requiring additional > +software to be installed. > +* Firefox version 47 requires manual installation of the Marionette driver; > +see https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette/WebDriver. > +Ensure that the Marionette executable (wires on Linux, wires.exe on Windows) > +is on your PATH. > > The test case will instantiate a Selenium driver set by the > TOASTER_TESTS_BROWSER environment variable, or Chrome if this is not specified. > diff --git a/bitbake/lib/toaster/tests/browser/selenium_helpers.py b/bitbake/lib/toaster/tests/browser/selenium_helpers.py > index 54db2e8..f3bb1a3 100644 > --- a/bitbake/lib/toaster/tests/browser/selenium_helpers.py > +++ b/bitbake/lib/toaster/tests/browser/selenium_helpers.py > @@ -34,6 +34,7 @@ import time > from django.contrib.staticfiles.testing import StaticLiveServerTestCase > from selenium import webdriver > from selenium.webdriver.support.ui import WebDriverWait > +from selenium.webdriver.common.desired_capabilities import DesiredCapabilities > from selenium.common.exceptions import NoSuchElementException, \ > StaleElementReferenceException, TimeoutException > > @@ -48,7 +49,9 @@ def create_selenium_driver(browser='chrome'): > service_args=["--verbose", "--log-path=selenium.log"] > ) > elif browser == 'firefox': > - return webdriver.Firefox() > + capabilities = DesiredCapabilities.FIREFOX > + capabilities['marionette'] = True > + return webdriver.Firefox(capabilities=capabilities) This will force the use of the marionette/geckodriver/wires for all versions of firefox (apparently it works with v45 onwards) too so, either we need to switch those capabilities depending on the version of firefox we find or we will need to clarify that you'll always need this external driver. > elif browser == 'ie': > return webdriver.Ie() > elif browser == 'phantomjs':