From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy-sun4i-usb: fix missing __iomem *
Date: Fri, 17 Jun 2016 18:55:52 +0530 [thread overview]
Message-ID: <5763FA60.1010900@ti.com> (raw)
In-Reply-To: <651219bb-fbab-18f8-fe89-bacd86c15e0d@redhat.com>
On Wednesday 08 June 2016 03:39 PM, Hans de Goede wrote:
> Hi,
>
> On 07-06-16 19:14, Ben Dooks wrote:
>> Fix the missing __iomem attribute in sun4i_usb_phy_write()
>> function. This fixes the following sparse warnings:
>>
>> drivers/phy/phy-sun4i-usb.c:178:39: warning: incorrect type in initializer
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:178:39: expected void *phyctl
>> drivers/phy/phy-sun4i-usb.c:178:39: got void [noderef] <asn:2>*
>> drivers/phy/phy-sun4i-usb.c:185:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:185:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:185:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:189:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:189:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:189:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:196:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:196:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:196:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:199:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:199:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:199:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:205:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:205:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:205:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:208:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:208:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:208:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:210:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:210:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:210:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:212:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:212:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:212:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:214:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:214:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:214:17: got void *phyctl
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> Thanks for catching this:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
applied, thanks.
-Kishon
>
> Regards,
>
> Hans
>
>
>> ---
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Cc: Chen-Yu Tsai <wens@csie.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: linux-arm-kernel at lists.infradead.org
>> ---
>> drivers/phy/phy-sun4i-usb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
>> index bae54f7..9de9991 100644
>> --- a/drivers/phy/phy-sun4i-usb.c
>> +++ b/drivers/phy/phy-sun4i-usb.c
>> @@ -175,7 +175,7 @@ static void sun4i_usb_phy_write(struct sun4i_usb_phy
>> *phy, u32 addr, u32 data,
>> {
>> struct sun4i_usb_phy_data *phy_data = to_sun4i_usb_phy_data(phy);
>> u32 temp, usbc_bit = BIT(phy->index * 2);
>> - void *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
>> + void __iomem *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
>> int i;
>>
>> mutex_lock(&phy_data->mutex);
>>
prev parent reply other threads:[~2016-06-17 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:14 [PATCH] phy-sun4i-usb: fix missing __iomem * Ben Dooks
2016-06-08 10:09 ` Hans de Goede
2016-06-17 13:25 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763FA60.1010900@ti.com \
--to=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.