All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>, David Ahern <dsa@cumulusnetworks.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, nogahf@mellanox.com, idosch@mellanox.com,
	eladr@mellanox.com, yotamg@mellanox.com, ogerlitz@mellanox.com,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	linville@tuxdriver.com, tgraf@suug.ch, gospo@cumulusnetworks.com,
	sfeldma@gmail.com, sd@queasysnail.net, eranbe@mellanox.com,
	ast@plumgrid.com, edumazet@google.com,
	hannes@stressinduktion.org, f.fainelli@gmail.com
Subject: Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats
Date: Fri, 17 Jun 2016 10:54:34 -0400	[thread overview]
Message-ID: <57640F2A.7090003@mojatatu.com> (raw)
In-Reply-To: <20160617140512.GB1981@nanopsycho.orion>

On 16-06-17 10:05 AM, Jiri Pirko wrote:
> Fri, Jun 17, 2016 at 03:48:35PM CEST, dsa@cumulusnetworks.com wrote:
>> On 6/17/16 2:24 AM, Jiri Pirko wrote:
>>>

>
> That is problematic. Existing apps depend on rtnetlink stats. But if we
> don't count offloaded forwarded packets, the apps don't see anything.
> Therefore I believe that this patchset approach is better. The existing
> apps continue to work and future apps can use newly introduces sw_stats
> to query slowpath traffic. Makes sense to me.
>

I agree with Jiri. It is a bad idea to depend on ethtool for any of
this stuff. Is there a way we can tag netlink stats instead
to indicate they are hardware or software?
We already have a use case with the tc where someone could get/set
hardware and/or software.

cheers,
jamal

  reply	other threads:[~2016-06-17 14:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16  8:37 [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats Jiri Pirko
2016-06-16  8:37 ` [patch net-next v4 1/4] netdevice: add SW statistics ndo Jiri Pirko
2016-06-16  8:37 ` [patch net-next v4 2/4] rtnetlink: add HW/SW stats distinction in rtnl_fill_stats Jiri Pirko
2016-06-16  8:37 ` [patch net-next v4 3/4] net: core: add SW stats to if_stats_msg Jiri Pirko
2016-06-17  0:20   ` David Miller
2016-06-17  7:32     ` Jiri Pirko
2016-06-16  8:37 ` [patch net-next v4 4/4] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default Jiri Pirko
2016-06-17  0:26 ` [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats David Miller
2016-06-17  8:24   ` Jiri Pirko
2016-06-17 13:48     ` David Ahern
2016-06-17 14:05       ` Jiri Pirko
2016-06-17 14:54         ` Jamal Hadi Salim [this message]
2016-06-17 14:57           ` Jiri Pirko
2016-06-17 15:35           ` David Ahern
2016-06-17 15:42             ` Jiri Pirko
2016-06-17 17:12               ` Florian Fainelli
2016-06-18  8:00                 ` Jiri Pirko
2016-06-18 13:58                   ` Jamal Hadi Salim
2016-06-19 10:57                     ` Jiri Pirko
2016-06-20  3:14                 ` Roopa Prabhu
2016-06-20 12:28                   ` Jamal Hadi Salim
2016-06-20 13:09                     ` Jiri Pirko
2016-06-22 14:30                     ` Roopa Prabhu
2016-06-20  3:06           ` Roopa Prabhu
2016-06-20  2:57         ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57640F2A.7090003@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=edumazet@google.com \
    --cc=eladr@mellanox.com \
    --cc=eranbe@mellanox.com \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=hannes@stressinduktion.org \
    --cc=idosch@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=nogahf@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=sd@queasysnail.net \
    --cc=sfeldma@gmail.com \
    --cc=tgraf@suug.ch \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.