[Intel-wired-lan] [next PATCH S38 6/7] i40e: refactor rx filter handling

[Shannon Nelson <sln@onemain.com>]

On 06/17/2016 08:53 AM, Williams, Mitch A wrote:
>>> From: Mitch Williams <mitch.a.williams@intel.com>
>>>
>>> Properly track filter adds and deletes so the driver doesn't lose filters
>>> during resets and up/down cycles. Add a tracking mechanism so that the
>>> driver knows when to enter and leave promiscuous mode.
>> Thanks, this was sorely needed.
> Yes, it was needed, but you should NOT CARE.

I care because I still want to use this driver as a high point on my 
resume :-).

[...]


>    struct i40e_mac_filter {
>    	struct list_head list;
>    	u8 macaddr[ETH_ALEN];
> @@ -456,8 +464,7 @@ struct i40e_mac_filter {
>    	u8 counter;		/* number of instances of this filter */
>    	bool is_vf;		/* filter belongs to a VF */
>    	bool is_netdev;		/* filter belongs to a netdev */
> -	bool changed;		/* filter needs to be sync'd to the HW */
> -	bool is_laa;		/* filter is a Locally Administered Address */
>> So you're dumping LAA support?  Or is this extra work no longer needed?
>> I would have expected some discussion of this in the commit notes.
> I'll update the commit message. It's currently looking like we don't need this code.

Perhaps you're using newer NVM?  Be sure to try it on an older NVM to 
see what happens to your LAA when you do a few different resets. I 
believe this code was specifically addressing an issue where the address 
register was getting reset on Global and Core resets.  See net-next 
commit 6252c7e4e from 2 years ago, which I believe references internal 
commit 6e643f9a59.

sln