From: Mat Martineau <mathew.j.martineau at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [MPTCP][PATCH v5 mptcp-next 0/9] RM_ADDR: remove a list of addrs
Date: Mon, 08 Feb 2021 17:57:51 -0800 [thread overview]
Message-ID: <5764998f-17f1-ece6-e8c5-8a2d758c864@linux.intel.com> (raw)
In-Reply-To: cover.1612795651.git.geliangtang@gmail.com
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Mon, 8 Feb 2021, Geliang Tang wrote:
> v5:
> - use struct mptcp_rm_list instead of the ids array.
> - simplify mptcp_pm_remove_addrs_and_subflows.
> - apply: tag export/20210207T062839 + patchset "move to next addr and
> testcases".
>
Thanks Geliang!
I only had a couple of minor comments doing visual code review, they
affect individual patches but not the final code. That's all I saw in
visual code review, I will look at the test output and pcaps tomorrow.
Have you tested what happens if there's an incoming rm_addr with id 0,
since we never send an ADD_ADDR for the initial subflow?
--
Mat Martineau
Intel
next reply other threads:[~2021-02-09 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 1:57 Mat Martineau [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 15:31 [MPTCP] Re: [MPTCP][PATCH v5 mptcp-next 0/9] RM_ADDR: remove a list of addrs Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5764998f-17f1-ece6-e8c5-8a2d758c864@linux.intel.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.