From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbcFROVY (ORCPT ); Sat, 18 Jun 2016 10:21:24 -0400 Received: from lists.s-osg.org ([54.187.51.154]:38137 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbcFROVW (ORCPT ); Sat, 18 Jun 2016 10:21:22 -0400 Message-ID: <576558DD.7060805@osg.samsung.com> Date: Sat, 18 Jun 2016 15:21:17 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Greg KH CC: Ravishankar Karkala Mallikarjunayya , abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c References: <1464413211-7947-1-git-send-email-ravishankarkm32@gmail.com> <1464413211-7947-4-git-send-email-ravishankarkm32@gmail.com> <574C4C67.4030106@osg.samsung.com> <20160618035122.GA1308@kroah.com> In-Reply-To: <20160618035122.GA1308@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/06/16 04:51, Greg KH wrote: > On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote: >> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: >>> This is a patch to the s626.c file that fixes up a line over 80 >>> characters issues found by the checkpatch.pl tool. >>> >>> Signed-off-by: Ravishankar Karkala Mallikarjunayya >> >> Looks good :) >> >> This is the only instance of the line over 80 characters Warning in that file. >> >> Like previous patches, no need to mention the file being fixed in the commit >> message. It isn't a big deal though. >> >> +1 > > Not much I can do with at "+1", please respond with a: > Acked-by: > or even better: > Reviewed-by: > > with the proper info, so I can add it to the patch and give you credit > for reviewing it. > > thanks, > > greg k-h > Reviewed-by: Luis de Bethencourt Sorry, sometimes I am not sure if my comments warrant an Acked-by/Reviewed-by. Will always add one from now on. Thanks :) Luis