From: sagigrim@gmail.com (Sagi Grimberg)
Subject: [PATCH 2/2] [RFC] nvme: enable asynchronous events notification by default
Date: Mon, 20 Jun 2016 09:55:17 +0300 [thread overview]
Message-ID: <57679355.6000303@gmail.com> (raw)
In-Reply-To: <1466184075-10471-3-git-send-email-gpiccoli@linux.vnet.ibm.com>
> Asynchronous events notification currently is disabled by default;
> to enable it, one should issue a set-feature command through
> nvme-cli userspace application. The tool also allows disabling
> these events once they're enable, as per user desire.
>
> This patch makes the asynchronous events notification enabled by
> default; to do so, we submit the set-feature command from the
> driver, in the end of nvme_reset_work() routine. This way, the
> feature is enabled on the driver initialization and after resets,
> in case they happen.
AEN was already enabled by default in:
commit f866fc4282a81673ef973ad54c68235a3263b42e
Author: Christoph Hellwig <hch at lst.de>
Date: Tue Apr 26 13:52:00 2016 +0200
nvme: move AER handling to common code
The transport driver still needs to do the actual submission, but
all the
higher level code can be shared.
Signed-off-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
Signed-off-by: Jens Axboe <axboe at fb.com>
(Assuming you have at least a single queue).
next prev parent reply other threads:[~2016-06-20 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 17:21 [PATCH 0/2] 2 patches about asynchronous events notification Guilherme G. Piccoli
2016-06-17 17:21 ` [PATCH 1/2] nvme: introduce asynchronous events textual output Guilherme G. Piccoli
2016-06-17 17:21 ` [PATCH 2/2] [RFC] nvme: enable asynchronous events notification by default Guilherme G. Piccoli
2016-06-20 6:55 ` Sagi Grimberg [this message]
2016-06-20 17:03 ` Guilherme G. Piccoli
2016-06-20 20:21 ` Keith Busch
2016-06-24 8:17 ` Christoph Hellwig
2016-06-28 15:11 ` Keith Busch
2016-06-29 4:17 ` Gabriel Krisman Bertazi
2016-07-06 22:47 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57679355.6000303@gmail.com \
--to=sagigrim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.