All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: fix warnings in pm.c
Date: Mon, 20 Jun 2016 09:47:25 +0200	[thread overview]
Message-ID: <57679F8D.5000406@atmel.com> (raw)
In-Reply-To: <1466177658-26179-1-git-send-email-ben.dooks@codethink.co.uk>

Le 17/06/2016 17:34, Ben Dooks a ?crit :
> Fix a pair of missing statics on un-exported functions and
> include <linux/platform_data/atmel.h> to provide the declaration
> of at91_suspend_entering_slow_clock() to fix the following
> sparse warnings:
> 
> arch/arm/mach-at91/pm.c:127:5: warning: symbol 'at91_suspend_entering_slow_clock' was not declared. Should it be static?
> arch/arm/mach-at91/pm.c:358:6: warning: symbol 'at91rm9200_idle' was not declared. Should it be static?
> arch/arm/mach-at91/pm.c:367:6: warning: symbol 'at91sam9_idle' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks Ben!

Bye,

> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  arch/arm/mach-at91/pm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index f062701..b4332b7 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -22,6 +22,7 @@
>  #include <linux/of_platform.h>
>  #include <linux/of_address.h>
>  #include <linux/platform_device.h>
> +#include <linux/platform_data/atmel.h>
>  #include <linux/io.h>
>  #include <linux/clk/at91_pmc.h>
>  
> @@ -355,7 +356,7 @@ static __init void at91_dt_ramc(void)
>  	at91_pm_set_standby(standby);
>  }
>  
> -void at91rm9200_idle(void)
> +static void at91rm9200_idle(void)
>  {
>  	/*
>  	 * Disable the processor clock.  The processor will be automatically
> @@ -364,7 +365,7 @@ void at91rm9200_idle(void)
>  	writel(AT91_PMC_PCK, pmc + AT91_PMC_SCDR);
>  }
>  
> -void at91sam9_idle(void)
> +static void at91sam9_idle(void)
>  {
>  	writel(AT91_PMC_PCK, pmc + AT91_PMC_SCDR);
>  	cpu_do_idle();
> 


-- 
Nicolas Ferre

      reply	other threads:[~2016-06-20  7:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 15:34 [PATCH] ARM: at91: fix warnings in pm.c Ben Dooks
2016-06-20  7:47 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57679F8D.5000406@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.