Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

[Zhang Chen <zhangchen.fnst@cn.fujitsu.com>]

On 06/20/2016 04:52 PM, Paolo Bonzini wrote:
>
> On 20/06/2016 10:23, Zhang Chen wrote:
>> We want to poll and handle chardev in another thread
>> other than main loop.
> Can you explain this better?

For example, we use this in codes:

+    qemu_chr_add_handlers(s->chr_sec_in, compare_chr_can_read,
+                          compare_sec_chr_in, NULL, s);

when data come to s->chr_sec_in ,we want to make
compare_sec_chr_in() run in another thread rather
than main loop.


Thanks
Zhang Chen

>
> Paolo
>
>> But qemu_chr_add_handlers() can only
>> work for global default context other than thread default context.
>> So we use g_souce_attach(xx, g_main_context_get_thread_default())
>> replace g_source_attach(xx, NULL) to attach g_source.
>> Comments form jason.
>>
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>
>

-- 
Thanks
zhangchen